docs: adjust review time expectations #3067
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
approved these changes
Nov 17, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
adnanhemani
approved these changes
Nov 17, 2025
Contributor
adnanhemani
left a comment
adnanhemani
left a comment
There was a problem hiding this comment.
I might recommend four or five working days if the change is quite intrusive (based on my personal experience) - but we can start here!
singhpk234
reviewed
Nov 18, 2025
| * Do not re-create a pull-request for the same change. Use one Pull Request related to the same change(s). The purpose here is to keep the history and all comments in the Pull Request. | ||
| * Consider open questions and concerns in all comments of your Pull Request, provide replies and resolve addressed comments, if those don't serve reference purposes. If a comment doesn't contain `nit`, `minor`, or `not a blocker` mention, please provide feedback to the comment before merging. | ||
| * Give time for review. For instance two working days is a good base to get first reviews and comments. | ||
| * Give time for review. For instance two working days is a good base to get first reviews and comments for changes that are not likely to affect downstream projects. For changes that touch core interfaces and behaviours three working days would be advisable. |
Contributor
There was a problem hiding this comment.
We discussed what we consider integration points here : https://lists.apache.org/thread/0nj24zro7kyctqfnlml08ppo7zs9xcqs, wondering if we should link it here or be a bit precise on expectation on what interface we should give additional time to review
Contributor
There was a problem hiding this comment.
Can we add that SPIs/APIs changes, as well as structural changes like a Java module added/removed?
MonkeyCanCode
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)