RATIS-2165. Do not include RaftClientRequest Message in ReadIndexRequest #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return toRaftClientRequestProto(request, true); | ||
| } | ||
|
|
||
| static RaftClientRequestProto toRaftClientRequestProto(RaftClientRequest request, boolean with_msg) { |
Contributor
There was a problem hiding this comment.
do not use with_msg, at least it should be withMsg
Contributor
Author
|
These failed tests seem to meet expectations |
szetszwo
approved these changes
Oct 8, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
szetszwo
changed the title
Contributor
@133tosakarin , you are right that the failures does not seem related; see #1156 . Let's merge this without further retries. |
OneSizeFitsQuorum
pushed a commit
that referenced
this pull request
Oct 9, 2024
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 23, 2025
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For the readIndexRequestProto, we don't need to set message member
In readIndex, we did not use clientRequest.message, so we do not need to serialize the message
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2165