RATIS-2151. TestRaftWithGrpc keeps failing with zero-copy. #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@duongkame , @133tosakarin , @OneSizeFitsQuorum , @adoroszlai , please take a look. |
133tosakarin
approved these changes
Oct 8, 2024
adoroszlai
reviewed
Oct 8, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for the patch, LGTM.
Contributor
Author
|
@adoroszlai , could you approve this? I guess no one else will review this. |
adoroszlai
approved these changes
Oct 11, 2024
Contributor
Author
|
@adoroszlai , thanks a lot for reviewing and approving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RATIS-2151
This is to fix the following problems described in #1156
3.
GrpcClientProtocolService.UnorderedRequestStreamObserver.processClientRequest(..)should use try-finally.4.
GrpcLogAppender.appendLog(..)callsrelease()incorrectly for exception.6.
LogSegmentcache can release an entry multiple times.7.
LogSegment.loadCache(..)should callretain()for cache hit.8.
SegmentedRaftLog.retainLog(..): between getting the entry and callingretain(), the entry can be released. The "fail to retain" exception, if there is any, can be ignored since It is the same as a cache miss. See #11539.
SegmentedRaftLog.retainEntryWithData(..)should release for exception.10. Test bug: the log entries stored in
SimpleStateMachine4Testingcan be released.11.
LogSegment: New entries can be added after EntryCache is closed.13.
SegmentedRaftLogWorkershould clean up unfinished tasks in the queue after stopped running.