changed tests according to requirement for feat: implement st_NumRings #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@petern48 can you check this PR ....I actually did the changes u mentioned but I am not sure how I solved merge conflicts....I mistakenly over looked it.Please let me know for any more further changes .I will add references and proper title if you review and approve the current changes ,Thank you. |
petern48
reviewed
Dec 3, 2025
Comment on lines
-2901
to
-2912
| ("MULTIPOINT ((0 0), (1 1))", 0), | ||
| ("MULTILINESTRING ((0 0, 1 1), (2 2, 3 3))", 0), | ||
| ("POINT EMPTY", 0), | ||
| ("MULTIPOINT EMPTY", 0), | ||
| ("LINESTRING EMPTY", 0), | ||
| ("MULTILINESTRING EMPTY", 0), | ||
| ("MULTIPOINT ((0 0), (1 1))", 0), | ||
| ("MULTILINESTRING ((0 0, 1 1), (2 2, 3 3))", 0), | ||
| ("POINT EMPTY", 0), | ||
| ("MULTIPOINT EMPTY", 0), | ||
| ("LINESTRING EMPTY", 0), | ||
| ("MULTILINESTRING EMPTY", 0), |
Collaborator
There was a problem hiding this comment.
but I am not sure how I solved merge conflicts
Yeah, looking at the change, this isn't quite the change we were trying to do here. It looks like you're running into complications given you're trying to re-use your old branch that was already merged. I recommend just fixing this in a fresh new branch:
- Delete this local branch
- Updating your local main branch with the most up-to-date main from this repo
- Create a new branch make your change
- Either force push to this remote branch
st_numringsso you can re-use this PR OR create a brand new PR and close this one. (Alternatively, just lump the change into your existing PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.