[SPARK-54122][SS] Implement TwsTester in Scala #53159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add TwsTester.scala: Main testing framework for TransformWithState - Add InMemoryStatefulProcessorHandleImpl.scala: In-memory implementation for testing - Add TwsTesterSuite.scala: Test suite for TwsTester framework - Add processors: EventTimeWindow, MultiTimer, RunningCount, SessionTimeout, TopK, WordFrequency
added 8 commits
November 21, 2025 21:11
added 18 commits
November 24, 2025 22:23
added 9 commits
January 5, 2026 22:02
HeartSaVioR
reviewed
Jan 7, 2026
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
Only minors and nits. Thanks for addressing all review comments!
...treaming/operators/stateful/transformwithstate/testing/InMemoryStatefulProcessorHandle.scala
Outdated
Show resolved
Hide resolved
...treaming/operators/stateful/transformwithstate/testing/InMemoryStatefulProcessorHandle.scala
Outdated
Show resolved
Hide resolved
...treaming/operators/stateful/transformwithstate/testing/InMemoryStatefulProcessorHandle.scala
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/streaming/TwsTester.scala
Outdated
Show resolved
Hide resolved
| * @param processor the StatefulProcessor to test. | ||
| * @param initialState initial state for each key as a list of (key, state) tuples. | ||
| * @param timeMode time mode (None, ProcessingTime or EventTime). | ||
| * @param outputMode output mode (Append, Update, or Complete). |
sql/core/src/test/scala/org/apache/spark/sql/streaming/TwsTesterSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TwsTesterSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TwsTesterSuite.scala
Outdated
Show resolved
Hide resolved
…ng/operators/stateful/transformwithstate/testing/InMemoryStatefulProcessorHandle.scala Co-authored-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
HeartSaVioR
approved these changes
Jan 9, 2026
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
+1 Thanks for your patience!
Contributor
|
I see CI fails with document generation, but it does not seem to come from this PR. |
Contributor
|
Thanks! Merging to master. |
sarutak
added a commit
that referenced
this pull request
Jan 9, 2026
### What changes were proposed in this pull request? This PR fixes an issue that illegal character `<` is used in block comment in `TwsTester.scala`, which was brought in #53159 and causes error when generating Javadoc. https://github.com/apache/spark/actions/runs/20839516325/job/59870814463 ``` [error] Generating /home/runner/work/spark/spark/target/javaunidoc/org/apache/spark/sql/streaming/TwsTester.html... ``` ### Why are the changes needed? To recover CI. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53746 from sarutak/fix-genjavadoc-error. Authored-by: Kousuke Saruta <sarutak@amazon.co.jp> Signed-off-by: Kousuke Saruta <sarutak@apache.org>
Yicong-Huang
pushed a commit
to Yicong-Huang/spark
that referenced
this pull request
Jan 9, 2026
### What changes were proposed in this pull request? * Added TwsTester, a test helper for writing unit tests for StatefulProcessor implementations that will be used in TransformWithState operator in streaming queries. It processes input rows and returns output rows equivalent to those that would be produced by the processor in an actual Spark streaming query. * Supported functionality: * Processing input rows and producing output rows via `test()`. * Initial state setup via constructor parameter. * Direct state manipulation via `setValueState`, `setListState`, `setMapState`. * Direct state inspection via `peekValueState`, `peekListState`, `peekMapState`. * Timers (both ProcessingTime and EventTime modes). * TTL. * Real-time mode simulation. * This is implemented in Scala. Equivalent TwsTester in Python for PySpark will be added in apache#53491. ### Why are the changes needed? Some users requested unit testing functionality for TWS. ### Does this PR introduce _any_ user-facing change? Yes, it adds new public API to Spark: * org.apache.spark.sql.streaming.TwsTester in Scala. ### How was this patch tested? Added unit and end-to-end tests in this PR. End-to-end tests compare TwsTester output with results of a real streaming query. ### Was this patch authored or co-authored using generative AI tooling? Yes. Cursor with claude-4.5-sonnet was used to assist with coding and generate some of documentation and tests. Generated-by: claude-4.5-sonnet Closes apache#53159 from fedimser/tws-tester-3. Lead-authored-by: Dmytro Fedoriaka <dmytro.fedoriaka@databricks.com> Co-authored-by: Dmytro Fedoriaka <fedimser@users.noreply.github.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
Yicong-Huang
pushed a commit
to Yicong-Huang/spark
that referenced
this pull request
Jan 9, 2026
### What changes were proposed in this pull request? This PR fixes an issue that illegal character `<` is used in block comment in `TwsTester.scala`, which was brought in apache#53159 and causes error when generating Javadoc. https://github.com/apache/spark/actions/runs/20839516325/job/59870814463 ``` [error] Generating /home/runner/work/spark/spark/target/javaunidoc/org/apache/spark/sql/streaming/TwsTester.html... ``` ### Why are the changes needed? To recover CI. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#53746 from sarutak/fix-genjavadoc-error. Authored-by: Kousuke Saruta <sarutak@amazon.co.jp> Signed-off-by: Kousuke Saruta <sarutak@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
test().setValueState,setListState,setMapState.peekValueState,peekListState,peekMapState.Why are the changes needed?
Some users requested unit testing functionality for TWS.
Does this PR introduce any user-facing change?
Yes, it adds new public API to Spark:
How was this patch tested?
Added unit and end-to-end tests in this PR. End-to-end tests compare TwsTester output with results of a real streaming query.
Was this patch authored or co-authored using generative AI tooling?
Yes. Cursor with claude-4.5-sonnet was used to assist with coding and generate some of documentation and tests.
Generated-by: claude-4.5-sonnet