[SPARK-54527][CORE] Remove getRecoveryPath method from YarnShuffleService.java

[huangxiaopingRD]

What changes were proposed in this pull request?

Remove getRecoveryPath method from YarnShuffleService.java, it is no longer used.

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need test

Was this patch authored or co-authored using generative AI tooling?

No

[dongjoon-hyun]

May I ask why you think like that, @huangxiaopingRD ?

Remove getRecoveryPath method from YarnShuffleService.java, it is no longer used.

[huangxiaopingRD]

May I ask why you think like that, @huangxiaopingRD ?

Remove getRecoveryPath method from YarnShuffleService.java, it is no longer used.

@dongjoon-hyun Thank you for your reply. After this PR (https://github.com/apache/spark/pull/14999/files), getRecoveryPath is not used anywhere else.

[dongjoon-hyun]

However, we maintained both setter and getter methods like Apache Hadoop AuxiliaryService abstract class. I'm not sure it's a good idea for us to remove the only way to get the recovery path at Apache Spark 4.2.0.

public void setRecoveryPath(Path recoveryPath) {
protected Path getRecoveryPath(String fileName) {

IIUC, this is public class, isn't it?

spark/common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java

Line 101 in 154a270

public class YarnShuffleService extends AuxiliaryService {

[huangxiaopingRD]

However, we maintained both setter and getter methods like Apache Hadoop AuxiliaryService abstract class. I'm not sure it's a good idea for us to remove the only way to get the recovery path at Apache Spark 4.2.0.

public void setRecoveryPath(Path recoveryPath) {
protected Path getRecoveryPath(String fileName) {

IIUC, this is public class, isn't it?

spark/common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java

Line 101 in 154a270

public class YarnShuffleService extends AuxiliaryService {

I understand what you mean. Thank you @dongjoon-hyun