Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Conversation

@seian
Copy link
Contributor

@seian seian commented May 24, 2016

No description provided.

@seian
Copy link
Contributor Author

seian commented May 24, 2016

I updated the term threshold to limit but didn't change description on the documentation because it may make users confused.

@jihoonson
Copy link
Contributor

Ok. I'll review soon.
BTW, you don't have to close and make a new PR to update your patch. When you commit your patch to your repository, github automatically detects the changes and shows them in the existing PR.
Actually, this is the strongly encouraged way to update contributors' patch because previous discussions can be kept.

@seian
Copy link
Contributor Author

seian commented May 25, 2016

Thanks for the tip. What should I do if I have to change the whole code in my branch in case of some problems being out there and do code from scratch again? Do I have to do just rollback?

@jihoonson
Copy link
Contributor

Yes, it doesn't matter whatever you do using git commands. I think that there is only one exception, that is your local branch is accidentally broken, so you cannot continue your work on that branch.

"restriction for the total size of broadcasted table for non-cross join (kb)", DEFAULT, Long.class,
Validators.min("0")),
BROADCAST_CROSS_JOIN_THRESHOLD(ConfVars.$DIST_QUERY_BROADCAST_CROSS_JOIN_THRESHOLD,
BROADCAST_CROSS_JOIN_THRESHOLD(ConfVars.$DIST_QUERY_BROADCAST_CROSS_JOIN_LIMIT,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the above two session variables also need to be changed.

@jihoonson
Copy link
Contributor

Hi @seian, sorry for late review.
I left one comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants