This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-2059: Binary search in BST reader does compare too frequently #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Overall, this patch looks good to me. Would you check the test failures? |
Contributor
Author
|
@jihoonson |
| start = centerPos; | ||
| } | ||
|
|
||
| centerPos = (start + end) / 2; |
Contributor
There was a problem hiding this comment.
This line also looks to be changed to centerPos = (start + end) >>> 1;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simple test based on unit test was done with 1M tuples and searching 1M times.
Two columns, which are long and double, are used as sort key.
Count above is a number of invoking compare().
Current
find : 44 sec
count : 42001207
Patch
find : 43 sec
count : 20141495