Skip to content
This repository was archived by the owner on Jan 17, 2025. It is now read-only.

Update _variables.scss #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

dariocarbone
Copy link

Quick fix for bootstrap 5.3.0

See:
#75 (comment)

Quick fix for bootstrap 5.3.0

See: 
apalfrey#75 (comment)
@f1mishutka
Copy link

f1mishutka commented Jun 2, 2023

Hi,

Replacing $s2bs5-border-color with raw red color is not so good solution.

Originally there is $s2bs5-border-color variable used. If you trace it to final definition you would have this chain of assignments:
$s2bs5-border-color = $form-select-border-color = $input-border-color = $border-color

So correct solution would be to change line 28 of _variables.scss from:

$s2bs5-border-color:             var(--#{$prefix}form-select-border-color) !default;

to

$s2bs5-border-color:             $border-color !default;

This eliminates compilation bug and does not changes color value in variable.

@f1mishutka
Copy link

Fast solution before this PR is merged is to add this line before importing select2-bootstrap-5-theme:

$s2bs5-border-color: $border-color;

Committed better solution seen here:

apalfrey#82 (comment)
@dariocarbone
Copy link
Author

Thanks, you're absolutely right: this is a better solution, promptly committed to master branch

@mmarton
Copy link

mmarton commented Oct 3, 2023

Any update on this?

@Jir4
Copy link

Jir4 commented Nov 29, 2023

Any news ?

@GaetanRole
Copy link

Up ? It is clearly fast to merge this PR @apalfrey , thanks

@wreiske
Copy link

wreiske commented Dec 6, 2024

Looking forward to this! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants