Add SwiftPM support, GitHub Actions CI. #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clean up most swiftlint errors and warnings.
- rare occurrence during certain race conditions. - example situation would be the search results being being the result of a async call.
Add Swift PM Support
* add GitHub Actions * Update github action and remove redundant dependencies. - github action should now use linux to run swiftlint - these can be installed locally with `brew install swiftlint` and `brew install swiftformat` - left the config files for both. * add xcodeproj and fix SwiftLint error * Run build against iOS SDK
add ci badge to readme
Author
|
The Github action I added is very simple. As there are no pre-existing test cases, I just run a build, and SwiftLint. If the build is successful and there are no serious code quality complaints from SwiftLint, the GitHub action will succeed. For the SPM support, best practice would be to cut a release. On the fork I created, I added a 1.2.6 tag. I would suggest doing the same here once this branch is merged. Otherwise users will have to use a branch or a commit SHA with SPM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install swiftlint, run withswiftlintbrew install swiftformat, run withswiftformat . --swiftversion=5.2