Add missing param type

phpstan.neon.dist

@@ -149,7 +149,6 @@ parameters:
 				- src/Symfony/Bundle/Test
 				- src/Symfony/Tests
 				- tests
-				- src # TODO
 		-
 			identifier: missingType.return
 			paths:

src/Doctrine/Common/Filter/BackedEnumFilterTrait.php

@@ -89,7 +89,7 @@ abstract protected function normalizePropertyName(string $property): string;
      */
     abstract protected function isBackedEnumField(string $property, string $resourceClass): bool;
 
-    private function normalizeValue($value, string $property): mixed
+    private function normalizeValue(mixed $value, string $property): mixed
     {
         $firstCase = $this->enumTypes[$property]::cases()[0] ?? null;
         if (

src/Doctrine/Common/Filter/BooleanFilterTrait.php

@@ -75,7 +75,7 @@ protected function isBooleanField(string $property, string $resourceClass): bool
         return isset(self::DOCTRINE_BOOLEAN_TYPES[(string) $this->getDoctrineFieldType($property, $resourceClass)]);
     }
 
-    private function normalizeValue($value, string $property): ?bool
+    private function normalizeValue(mixed $value, string $property): ?bool
     {
         if (\in_array($value, [true, 'true', '1'], true)) {
             return true;

src/Doctrine/Common/Filter/DateFilterTrait.php

@@ -81,7 +81,7 @@ protected function getFilterDescription(string $property, string $period): array
         ];
     }
 
-    private function normalizeValue($value, string $operator): ?string
+    private function normalizeValue(mixed $value, string $operator): ?string
     {
         if (false === \is_string($value)) {
             $this->getLogger()->notice('Invalid filter ignored', [

src/Doctrine/Common/Filter/ExistsFilterTrait.php

@@ -70,7 +70,7 @@ abstract protected function getLogger(): LoggerInterface;
 
     abstract protected function normalizePropertyName(string $property): string;
 
-    private function normalizeValue($value, string $property): ?bool
+    private function normalizeValue(mixed $value, string $property): ?bool
     {
         if (\in_array($value, [true, 'true', '1', '', null], true)) {
             return true;

src/Doctrine/Common/Filter/NumericFilterTrait.php

@@ -79,7 +79,7 @@ protected function isNumericField(string $property, string $resourceClass): bool
         return isset(self::DOCTRINE_NUMERIC_TYPES[(string) $this->getDoctrineFieldType($property, $resourceClass)]);
     }
 
-    protected function normalizeValues($value, string $property): ?array
+    protected function normalizeValues(mixed $value, string $property): ?array
     {
         if (!is_numeric($value) && (!\is_array($value) || !$this->isNumericArray($value))) {
             $this->getLogger()->notice('Invalid filter ignored', [

src/Doctrine/Common/Filter/OrderFilterTrait.php

@@ -14,6 +14,7 @@
 namespace ApiPlatform\Doctrine\Common\Filter;
 
 use ApiPlatform\Doctrine\Common\PropertyHelperTrait;
+use ApiPlatform\Metadata\Exception\InvalidArgumentException;
 
 /**
  * Trait for ordering the collection by given properties.
@@ -70,13 +71,21 @@ abstract protected function getProperties(): ?array;
 
     abstract protected function normalizePropertyName(string $property): string;
 
-    private function normalizeValue($value, string $property): ?string
+    private function normalizeValue(mixed $value, string $property): ?string
     {
         if (empty($value) && null !== $defaultDirection = $this->getProperties()[$property]['default_direction'] ?? null) {
             // fallback to default direction
             $value = $defaultDirection;
         }
 
+        if (!\is_string($value)) {
+            $this->getLogger()->notice('Invalid filter ignored', [
+                'exception' => new InvalidArgumentException(\sprintf('Invalid string value for "%s" property', $property)),
+            ]);
+
+            return null;
+        }
+
         $value = strtoupper($value);
         if (!\in_array($value, [self::DIRECTION_ASC, self::DIRECTION_DESC], true)) {
             return null;

src/Doctrine/Common/State/PersistProcessor.php

@@ -110,7 +110,7 @@ public function process(mixed $data, Operation $operation, array $uriVariables =
     /**
      * Checks if doctrine does not manage data automatically.
      */
-    private function isDeferredExplicit(DoctrineObjectManager $manager, $data): bool
+    private function isDeferredExplicit(DoctrineObjectManager $manager, object $data): bool
     {
         $classMetadata = $manager->getClassMetadata($this->getObjectClass($data));
         if ($classMetadata && method_exists($classMetadata, 'isChangeTrackingDeferredExplicit')) { // @phpstan-ignore-line metadata can be null

src/Doctrine/Common/State/RemoveProcessor.php

@@ -40,7 +40,7 @@ public function process(mixed $data, Operation $operation, array $uriVariables =
     /**
      * Gets the Doctrine object manager associated with given data.
      */
-    private function getManager($data): ?DoctrineObjectManager
+    private function getManager(mixed $data): ?DoctrineObjectManager
     {
         return \is_object($data) ? $this->managerRegistry->getManagerForClass($this->getObjectClass($data)) : null;
     }

src/Doctrine/Odm/Filter/AbstractFilter.php

@@ -60,7 +60,7 @@ public function apply(Builder $aggregationBuilder, string $resourceClass, ?Opera
     /**
      * Passes a property through the filter.
      */
-    abstract protected function filterProperty(string $property, $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void;
+    abstract protected function filterProperty(string $property, mixed $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void;
 
     public function hasManagerRegistry(): bool
     {

src/Doctrine/Odm/Filter/BooleanFilter.php

@@ -118,7 +118,7 @@ final class BooleanFilter extends AbstractFilter implements JsonSchemaFilterInte
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
+    protected function filterProperty(string $property, mixed $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
     {
         if (
             !$this->isPropertyEnabled($property, $resourceClass)

src/Doctrine/Odm/Filter/DateFilter.php

@@ -134,7 +134,7 @@ final class DateFilter extends AbstractFilter implements DateFilterInterface, Js
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
+    protected function filterProperty(string $property, mixed $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
     {
         // Expect $value to be an array having the period as keys and the date value as values
         if (
@@ -202,7 +202,7 @@ protected function filterProperty(string $property, $value, Builder $aggregation
     /**
      * Adds the match stage according to the chosen null management.
      */
-    private function addMatch(Builder $aggregationBuilder, string $field, string $operator, $value, ?string $nullManagement = null): void
+    private function addMatch(Builder $aggregationBuilder, string $field, string $operator, mixed $value, ?string $nullManagement = null): void
     {
         $value = $this->normalizeValue($value, $operator);
 

src/Doctrine/Odm/Filter/ExistsFilter.php

@@ -143,7 +143,7 @@ public function apply(Builder $aggregationBuilder, string $resourceClass, ?Opera
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
+    protected function filterProperty(string $property, mixed $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
     {
         if (
             !$this->isPropertyEnabled($property, $resourceClass)

src/Doctrine/Odm/Filter/NumericFilter.php

@@ -122,7 +122,7 @@ final class NumericFilter extends AbstractFilter implements JsonSchemaFilterInte
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
+    protected function filterProperty(string $property, mixed $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
     {
         if (
             !$this->isPropertyEnabled($property, $resourceClass)

src/Doctrine/Odm/Filter/OrderFilter.php

@@ -253,7 +253,7 @@ public function apply(Builder $aggregationBuilder, string $resourceClass, ?Opera
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
+    protected function filterProperty(string $property, mixed $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
     {
         if (!$this->isPropertyEnabled($property, $resourceClass) || !$this->isPropertyMapped($property, $resourceClass)) {
             return;

src/Doctrine/Odm/Filter/RangeFilter.php

@@ -115,7 +115,7 @@ final class RangeFilter extends AbstractFilter implements RangeFilterInterface,
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $values, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
+    protected function filterProperty(string $property, mixed $values, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
     {
         if (
             !\is_array($values)

src/Doctrine/Odm/Filter/SearchFilter.php

@@ -162,7 +162,7 @@ protected function getPropertyAccessor(): PropertyAccessorInterface
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
+    protected function filterProperty(string $property, mixed $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
     {
         if (
             null === $value

src/Doctrine/Odm/PropertyInfo/DoctrineExtractor.php

@@ -41,6 +41,8 @@ public function __construct(private readonly ObjectManager $objectManager)
     /**
      * {@inheritdoc}
      *
+     * @param string $class
+     *
      * @return string[]|null
      */
     public function getProperties($class, array $context = []): ?array
@@ -111,6 +113,9 @@ public function getType(string $class, string $property, array $context = []): ?
      *
      * // deprecated since 4.2 use "getType" instead
      *
+     * @param string $class
+     * @param string $property
+     *
      * @return LegacyType[]|null
      */
     public function getTypes($class, $property, array $context = []): ?array
@@ -183,6 +188,9 @@ public function getTypes($class, $property, array $context = []): ?array
 
     /**
      * {@inheritdoc}
+     *
+     * @param string $class
+     * @param string $property
      */
     public function isReadable($class, $property, array $context = []): ?bool
     {
@@ -191,6 +199,9 @@ public function isReadable($class, $property, array $context = []): ?bool
 
     /**
      * {@inheritdoc}
+     *
+     * @param string $class
+     * @param string $property
      */
     public function isWritable($class, $property, array $context = []): ?bool
     {

src/Doctrine/Orm/Extension/DoctrinePaginatorFactory.php

@@ -13,10 +13,16 @@
 
 namespace ApiPlatform\Doctrine\Orm\Extension;
 
+use Doctrine\ORM\Query;
+use Doctrine\ORM\QueryBuilder;
 use Doctrine\ORM\Tools\Pagination\Paginator;
 
 class DoctrinePaginatorFactory
 {
+    /**
+     * @param Query|QueryBuilder $query
+     * @param bool               $fetchJoinCollection
+     */
     public function getPaginator($query, $fetchJoinCollection): Paginator
     {
         return new Paginator($query, $fetchJoinCollection);

src/Doctrine/Orm/Filter/AbstractFilter.php

@@ -57,7 +57,7 @@ public function apply(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $q
      * @param class-string         $resourceClass
      * @param array<string, mixed> $context
      */
-    abstract protected function filterProperty(string $property, $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void;
+    abstract protected function filterProperty(string $property, mixed $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void;
 
     public function hasManagerRegistry(): bool
     {

src/Doctrine/Orm/Filter/BooleanFilter.php

@@ -119,7 +119,7 @@ final class BooleanFilter extends AbstractFilter implements JsonSchemaFilterInte
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
+    protected function filterProperty(string $property, mixed $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
     {
         if (
             !$this->isPropertyEnabled($property, $resourceClass)

src/Doctrine/Orm/Filter/DateFilter.php

@@ -143,7 +143,7 @@ final class DateFilter extends AbstractFilter implements DateFilterInterface, Js
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
+    protected function filterProperty(string $property, mixed $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
     {
         // Expect $value to be an array having the period as keys and the date value as values
         if (

src/Doctrine/Orm/Filter/ExistsFilter.php

@@ -150,7 +150,7 @@ public function apply(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $q
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
+    protected function filterProperty(string $property, mixed $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
     {
         if (
             !$this->isPropertyEnabled($property, $resourceClass)

src/Doctrine/Orm/Filter/NumericFilter.php

@@ -128,7 +128,7 @@ final class NumericFilter extends AbstractFilter implements JsonSchemaFilterInte
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
+    protected function filterProperty(string $property, mixed $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
     {
         if (
             !$this->isPropertyEnabled($property, $resourceClass)

src/Doctrine/Orm/Filter/OrderFilter.php

@@ -252,7 +252,7 @@ public function apply(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $q
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
+    protected function filterProperty(string $property, mixed $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
     {
         if (!$this->isPropertyEnabled($property, $resourceClass) || !$this->isPropertyMapped($property, $resourceClass)) {
             return;

src/Doctrine/Orm/Filter/RangeFilter.php

@@ -116,7 +116,7 @@ final class RangeFilter extends AbstractFilter implements RangeFilterInterface,
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $values, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
+    protected function filterProperty(string $property, mixed $values, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
     {
         if (
             !\is_array($values)

src/Doctrine/Orm/Filter/SearchFilter.php

@@ -161,7 +161,7 @@ protected function getPropertyAccessor(): PropertyAccessorInterface
     /**
      * {@inheritdoc}
      */
-    protected function filterProperty(string $property, $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
+    protected function filterProperty(string $property, mixed $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void
     {
         if (
             null === $value

src/Elasticsearch/Serializer/ItemNormalizer.php

@@ -77,6 +77,9 @@ public function supportsNormalization(mixed $data, ?string $format = null, array
         return DocumentNormalizer::FORMAT !== $format && $this->decorated->supportsNormalization($data, $format);
     }
 
+    /**
+     * @param string|null $format
+     */
     public function getSupportedTypes($format): array
     {
         return DocumentNormalizer::FORMAT !== $format ? $this->decorated->getSupportedTypes($format) : [];

src/GraphQl/Action/GraphiQlAction.php

@@ -26,6 +26,9 @@
  */
 final class GraphiQlAction
 {
+    /**
+     * @param string|null $assetPackage
+     */
     public function __construct(private readonly TwigEnvironment $twig, private readonly RouterInterface $router, private readonly bool $graphiqlEnabled = false, private readonly string $title = '', private $assetPackage = null)
     {
     }

src/GraphQl/ExecutorInterface.php

@@ -25,6 +25,8 @@ interface ExecutorInterface
 {
     /**
      * @see http://webonyx.github.io/graphql-php/executing-queries/#using-facade-method
+     *
+     * @param mixed $source
      */
     public function executeQuery(Schema $schema, $source, mixed $rootValue = null, mixed $context = null, ?array $variableValues = null, ?string $operationName = null, ?callable $fieldResolver = null, ?array $validationRules = null): ExecutionResult;
 }

src/GraphQl/Resolver/ResourceFieldResolver.php

@@ -32,6 +32,9 @@ public function __construct(private readonly IriConverterInterface $iriConverter
     {
     }
 
+    /**
+     * @param array $context
+     */
     public function __invoke(?array $source, array $args, $context, ResolveInfo $info): mixed
     {
         $property = null;

src/GraphQl/Serializer/Exception/ErrorNormalizer.php

@@ -40,6 +40,9 @@ public function supportsNormalization(mixed $data, ?string $format = null, array
         return $data instanceof Error;
     }
 
+    /**
+     * @param string|null $format
+     */
     public function getSupportedTypes($format): array
     {
         return [

src/GraphQl/Serializer/Exception/HttpExceptionNormalizer.php

@@ -51,6 +51,9 @@ public function supportsNormalization(mixed $data, ?string $format = null, array
         return $data instanceof Error && $data->getPrevious() instanceof HttpExceptionInterface;
     }
 
+    /**
+     * @param string|null $format
+     */
     public function getSupportedTypes($format): array
     {
         return [

src/GraphQl/Serializer/Exception/RuntimeExceptionNormalizer.php

@@ -45,6 +45,9 @@ public function supportsNormalization(mixed $data, ?string $format = null, array
         return $data instanceof Error && $data->getPrevious() instanceof \RuntimeException;
     }
 
+    /**
+     * @param string|null $format
+     */
     public function getSupportedTypes($format): array
     {
         return [

src/GraphQl/Serializer/Exception/ValidationExceptionNormalizer.php

@@ -80,6 +80,9 @@ public function supportsNormalization(mixed $data, ?string $format = null, array
         return $data instanceof Error && ($data->getPrevious() instanceof ConstraintViolationListAwareExceptionInterface);
     }
 
+    /**
+     * @param string|null $format
+     */
     public function getSupportedTypes($format): array
     {
         return [