Skip to content

Conversation

@karenheckel
Copy link
Contributor

@karenheckel karenheckel commented Dec 4, 2025

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

  • Fixes [Request]: Storage - Add configuration for default container disk capacity #887
  • This change adds support for specifying a default disk capacity. This allows users to define global storage defaults without needing to pass --storage each time they run a container. It aligns disk capacity behavior with the existing CPU and memory default configuration.
  • Added rootfs.storage to the system property configuration.
  • Added validation logic to ensure the user-specified capacity does not exceed available host space.

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@github-actions github-actions bot added the cli label Dec 5, 2025
Copy link
Contributor

@jglogan jglogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! I've left a couple of questions and minor change requests in the comments.

@karenheckel karenheckel changed the title Enable configurable default disk capacity for native and builder containers Feat: enable configurable default disk capacity for native and builder containers Dec 8, 2025
@karenheckel karenheckel requested a review from jglogan December 8, 2025 00:26
@jglogan
Copy link
Contributor

jglogan commented Dec 10, 2025

@karenheckel AFAICT I see one test failure:

◇ Test testBuilderStorageFlag() started.
✘ Test testBuilderStorageFlag() recorded an issue at CLIBuilderLifecycleTest.swift:73:17: Expectation failed: (abs(reportedMiB - expectedMiB) → 511968) <= (tolerance → 409)
↳ expected root filesystem size ≈ 4096 MiB for storage 4096MB, got 516064 MiB

@karenheckel
Copy link
Contributor Author

karenheckel commented Dec 11, 2025

@jplogan We have the plumbing set up for configuring the disk storage. However, we think that the underlying container runtime ignores the resources.storage field since the Containerization backend isn't wired to it yet, so the VM still boots with the default disk image size. A follow-up PR could extend the VM layer to actually size the rootfs block device according to resources.storage.

If there is something we are not understanding correctly, please feel free to let us know!

@karenheckel
Copy link
Contributor Author

karenheckel commented Dec 12, 2025

@jglogan We have attempted to provide backend support for the storage configuration support. Here is that pull request. The frontend (this PR) works, but the backend hasn't fully worked locally. If you have any suggestions, we would love to hear them. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Storage - Add configuration for default container disk capacity

3 participants