-
Notifications
You must be signed in to change notification settings - Fork 566
Feat: enable configurable default disk capacity for native and builder containers #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
jglogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing! I've left a couple of questions and minor change requests in the comments.
…command vs provided through the user default"
|
@karenheckel AFAICT I see one test failure: ◇ Test testBuilderStorageFlag() started.
✘ Test testBuilderStorageFlag() recorded an issue at CLIBuilderLifecycleTest.swift:73:17: Expectation failed: (abs(reportedMiB - expectedMiB) → 511968) <= (tolerance → 409)
↳ expected root filesystem size ≈ 4096 MiB for storage 4096MB, got 516064 MiB |
|
@jplogan We have the plumbing set up for configuring the disk storage. However, we think that the underlying container runtime ignores the If there is something we are not understanding correctly, please feel free to let us know! |
|
@jglogan We have attempted to provide backend support for the storage configuration support. Here is that pull request. The frontend (this PR) works, but the backend hasn't fully worked locally. If you have any suggestions, we would love to hear them. Thank you! |
Type of Change
Motivation and Context
--storageeach time they run a container. It aligns disk capacity behavior with the existing CPU and memory default configuration.rootfs.storageto the system property configuration.Testing