-
Notifications
You must be signed in to change notification settings - Fork 566
Disk io feature #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Disk io feature #954
Conversation
…atie's security recommendations
af5432e to
24599bd
Compare
| let estimatedReadOps = Double(totalReadBytes) / 4096.0 | ||
| let estimatedWriteOps = Double(totalWriteBytes) / 4096.0 | ||
|
|
||
| // TODO: Collect latency metrics from Containerization framework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to accept this until we actually have the stats to report.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcantah should i close the whole pr or should i fix the code particualr code ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, fixing the code requires some Containerization changes to actually get these stats in some form. I think we'd want to think about what to actually expose, how expensive it is to grab them etc. I'd probably just make this PR a draft for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, fixing the code requires some Containerization changes to actually get these stats in some form. I think we'd want to think about what to actually expose, how expensive it is to grab them etc. I'd probably just make this PR a draft for now
For sure I'll make this draft and look into containerization repo and see where can we fix this
Type of Change
Motivation and Context
Closes #950
Apple Container currently lacks detailed per-container filesystem performance metrics (IOPS, latency, fsync frequency, queue depth, storage backend type), making it difficult to diagnose I/O bottlenecks in database workloads, build systems, and ML pipelines.
The fix:
Add
--ioflag tocontainer statscommand that displays detailed filesystem performance metrics:Testing