Fix bash completion source path in documentation #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example was sourcing from the wrong path. It should source from ~/.bash_completions/container (where the script was just created) not from /opt/homebrew/etc/bash_completion.d/container (which is the path for when bash-completion is installed via homebrew).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
In the section about installing bash completions without the bash-completion package, line 574 of
docs/how-to.mdincorrectly instructs users to source from/opt/homebrew/etc/bash_completion.d/container, but the script was just created in~/.bash_completions/containeron line 573.The homebrew path is only relevant when using bash-completion (covered earlier in the same section). This fix ensures the example is internally consistent.
Test plan
~/.bash_completions/containeron line 573