Skip to content

Conversation

@sebimarkgraf
Copy link
Contributor

Closely related to apple/container#305 I would like to override the used SSL TrustRoots via standard env variables.

This here would add this configuration and would give an entrypoint for an implementation of 305 to provide CLI flags or similar.

This has no tests yet, as this would require setting up something like a MITM proxy when testing against a registry.
As I am unfamiliar with the codebase, I would be willing to do this, but would require a first nudge on where to best implement this.

To actually use this, we would need to add the allowed env variables to the container system start command env filter.

@sebimarkgraf sebimarkgraf force-pushed the sm/add-ssl-custom-ca branch 2 times, most recently from 6cf78b3 to 5c79a31 Compare November 14, 2025 10:03
Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move the tlsConfiguration parameter one spot up above the logger, I'd like to leave the logger as the last parameter. We're free to make breaking changes here until 1.0. This LGTM after, thanks!

@sebimarkgraf sebimarkgraf force-pushed the sm/add-ssl-custom-ca branch 2 times, most recently from 9bb47fa to a75f656 Compare December 9, 2025 10:47
@sebimarkgraf
Copy link
Contributor Author

I'd move the tlsConfiguration parameter one spot up above the logger, I'd like to leave the logger as the last parameter.

Moved the tlsConfiguration above the logger :)

@sebimarkgraf
Copy link
Contributor Author

@dcantah Sorry for pinging again, but I am currently cleaning up my PRs before moving into the next year.

Is there anything left for me to do or is this just waiting for a good time to merge?

@dcantah
Copy link
Member

dcantah commented Dec 18, 2025

@sebimarkgraf Nothing at all, sorry! Just been a bit backed up. Will check this in after green CI!

@dcantah
Copy link
Member

dcantah commented Dec 18, 2025

@sebimarkgraf Sorry, do you mind rebasing on main and repushing 😅. That should fix the CI failure

@dcantah dcantah force-pushed the sm/add-ssl-custom-ca branch from a75f656 to 74bf462 Compare December 18, 2025 23:05
@dcantah
Copy link
Member

dcantah commented Dec 18, 2025

Lovely, first time trying the rebase UI but we require verified signatures so that just doesn't work 😄. Just rebase and force push here and we should be good to check in

@sebimarkgraf
Copy link
Contributor Author

Rebase is done :)

@dcantah dcantah merged commit 02bd878 into apple:main Dec 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants