Fix immediate output getattr #2541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritolol
force-pushed
the
fix-immediate-output-getattr
branch
from
092ebff to
7eee9a9
Compare
|
@tritolol thanks for the pull request. I apologize that no one seems to have looked at this. Please rebase this change on top of tip of |
tritolol
force-pushed
the
fix-immediate-output-getattr
branch
from
600f0d8 to
5d51d4f
Compare
|
@TobyRoseman I'm not sure if you are automatically notified, so just in case you are not: The rebase is done. |
|
@TobyRoseman are any of the failing tests related to this PR? There is no indication of that for me. |
|
@tritolol - I don't think those failures are related to this change. Please rebase this change on top the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2538.
Changed
remove_getattr_nodes()such that it adds a new constant op if it encounters a getattr op that is part of the graph's output. Before it raised an error wich caused some networks not to convert.Added a unit test for the scenario.