Skip to content

Feature/updates v4 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
clintkitson wants to merge 1 commit into
base: v4-api
Choose a base branch
from
Open

Feature/updates v4 #3

clintkitson wants to merge 1 commit into from

Conversation

@clintkitson
Copy link

@clintkitson clintkitson commented Dec 20, 2015

This PR is compatible with the v4 SOAP API.

@clintkitson
Update for a docker driver
967c729 
This commit enables a fully functioning volume driver that is
able to run from VMs in VirtualBox and perform introspection
necessary to issue commands to underlying VB SOAP API
to perform storage orchestration for volume attachemnt.
@clintkitson clintkitson changed the title v4 updates Feature/updates v4 Dec 20, 2015
@clintkitson clintkitson mentioned this pull request Dec 20, 2015
Closed
@md5 md5 self-assigned this Dec 21, 2015
@md5
Copy link
Member

md5 commented Dec 21, 2015

It looks like this PR still has the Returnval stuff and the commenting out of the log.Println lines in the gowsdl-generated code.

Also, I still don't feel comfortable with the XMLName declaration being commented out from IMediumAttachment without better understanding what problems it's solving.

As for reviewing the bulk of the code in virtualboxclient, that may take me a bit to get to. I'm assuming you want me to prioritize the V5 changes in #2, correct?

@clintkitson
Copy link
Author

clintkitson commented Dec 22, 2015

Yes, the v4 stuff is based on original work. The v5 stuff should have priority. I haven't had a chance to run the WSDL through the updated tool. Once I do I will post in an error example re the returnval being commented out.

@md5
Copy link
Member

md5 commented Dec 22, 2015

Thanks @clintonskitson. I've asked the gowsdl maintainer whether a new release will be cut soon, since you'd currently have to build gowsdl yourself (which isn't a big deal, but is extra work).

@md5
Copy link
Member

md5 commented Dec 22, 2015

gowsdl 0.2.1 is now released and includes your fixes to the err handling.

@md5 md5 mentioned this pull request May 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@md5 md5

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clintkitson @md5