Skip to content

Conversation

@salevine
Copy link
Contributor

@salevine salevine commented Dec 30, 2025

Description

Update the sub text description on the Custom Domain label for clarity

Fixes 8476

Automation

/ok-to-test tags="@tag.Perf"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/20588545481
Commit: aefc643
Cypress dashboard.
Tags: @tag.Perf
Spec:
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
List of identified flaky tests.
Tue, 30 Dec 2025 04:36:41 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

Release Notes

  • Documentation
    • Clarified custom domain configuration guidance to specify that domains should be entered without the HTTP/HTTPS protocol.

✏️ Tip: You can customize this high-level summary in your review settings.

@salevine salevine requested a review from tomjose92 December 30, 2025 04:02
@salevine salevine added the ok-to-test Required label for CI label Dec 30, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2025

Walkthrough

Updated the help text for the APPSMITH_CUSTOM_DOMAINS setting in the instance settings configuration to clarify that domain values should exclude HTTP/HTTPS protocols. This is a documentation-only change affecting a single file with no functional modifications.

Changes

Cohort / File(s) Summary
Instance Settings Documentation
app/client/src/ce/pages/AdminSettings/config/instanceSettings.ts
Updated subText for APPSMITH_CUSTOM_DOMAINS setting to clarify that custom domains should be specified without protocol prefixes (HTTP/HTTPS)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🌐 A domain walks in without its coat,
No HTTP-y protocols afloat,
Just the bare address, clean and neat,
Help text updated, now complete! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly describes the main change: updating the Custom Domain subtext for clarity, which aligns with the actual code modification.
Description check ✅ Passed The PR description includes the required issue reference, automation tags, test results, and communication confirmation. All essential sections are present.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Enhancement New feature or request label Dec 30, 2025
@tomjose92 tomjose92 changed the title feat:Update Custom Domain Subtext for clarity feat: update Custom Domain Subtext for clarity Dec 30, 2025
Copy link
Contributor

@tomjose92 tomjose92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to go

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request ok-to-test Required label for CI Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants