added len method #708
added len method #708
Conversation
bluepal-prasanthi-moparthi
force-pushed
the
feature/add-getall-with-length
branch
2 times, most recently
from
084e9aa to
3a61ef3
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bluepal-prasanthi-moparthi
force-pushed
the
feature/add-getall-with-length
branch
from
676496b to
4433ac8
Compare
| c.readIndex = 0 // Reset read position to allow Read() after Len() | ||
| } | ||
| return len(c.cachedResults) | ||
| } |
There was a problem hiding this comment.
Bug: Concurrent Access Causes Data Races
The Len() method modifies shared state (cached, cachedResults, cachedErrors, readIndex) without synchronization, creating race conditions when multiple goroutines call Len() or Read() concurrently on the same reader. The same reader instance could be accessed from multiple goroutines, causing data races and unpredictable behavior.
| c.readIndex = 0 // Reset read position to allow Read() after Len() | ||
| } | ||
| return len(c.cachedResults) | ||
| } |
There was a problem hiding this comment.
Bug: Concurrent Access Corrupts Shared Reader State
The Len() method modifies shared state (cached, cachedResults, cachedErrors, readIndex) without synchronization, creating race conditions when multiple goroutines call Len() or Read() concurrently on the same reader. The same reader instance could be accessed from multiple goroutines, causing data races and unpredictable behavior.
| c.readIndex = 0 // Reset read position to allow Read() after Len() | ||
| } | ||
| return len(c.cachedResults) | ||
| } |
There was a problem hiding this comment.
Bug: Race Conditions from Unsynchronized Shared State
The Len() method modifies shared state (cached, cachedResults, cachedErrors, readIndex) without synchronization, creating race conditions when multiple goroutines call Len() or Read() concurrently on the same reader. The same reader instance could be accessed from multiple goroutines, causing data races and unpredictable behavior.
| c.readIndex = 0 // Reset read position to allow Read() after Len() | ||
| } | ||
| return len(c.cachedResults) | ||
| } |
There was a problem hiding this comment.
Bug: Unsynchronized shared state leads to data races.
The Len() method modifies shared state (cached, cachedResults, cachedErrors, readIndex) without synchronization, creating race conditions when multiple goroutines call Len() or Read() concurrently on the same reader. The same reader instance could be accessed from multiple goroutines, causing data races and unpredictable behavior.
| c.readIndex = 0 // Reset read position to allow Read() after Len() | ||
| } | ||
| return len(c.cachedResults) | ||
| } |
There was a problem hiding this comment.
Bug: Concurrency Bug: Unsynchronized Shared State
The Len() method modifies shared state (cached, cachedResults, cachedErrors, readIndex) without synchronization, creating race conditions when multiple goroutines call Len() or Read() concurrently on the same reader. The same reader instance could be accessed from multiple goroutines, causing data races and unpredictable behavior.
Added len() method for collections CRUD operations
Closes: #686
Note
Adds Len() to collection CRUD response readers with caching, introduces shared ReadAll utilities, refactors readers to fix Old/New handling, and updates tests/benchmarks accordingly.
Len()toCollectionDocument*ResponseReaderinterfaces (create,read,update,replace,delete).Len()while preservingRead()iteration.shared.ReadAllReaderandshared.ReadAllIntoReaderutilities and wire them into readers.Old/Newhandling: per-item instance creation via cachedreflect.Typeand back-propagation to provided option objects.v2/arangodb/shared/read_all.gowith genericReadAllhelpers for readers (with and without into-parameter).ReadAll(...), validateLen()behavior implicitly via caching, and assertmeta.Oldpopulation for deletes.ReadDocumentsdirectly and minor setup cleanups.len()for Read methods undermaster.Written by Cursor Bugbot for commit 4433ac8. This will update automatically on new commits. Configure here.