Skip to content

Conversation

jayamrutiya
Copy link
Contributor

Summary

Removed a redundant conditional operator in the upload logic that caused
a SonarQube TypeScript:S3923 issue.

Changes

  • Simplified file selection:
    const file = multiple ? acceptedFiles[0] : acceptedFiles[0];
    const file = acceptedFiles[0];

Motivation

  • Improve readability and maintain clean, maintainable code.
  • Ensure compliance with SonarQube rule TypeScript:S3923.

Impact

  • No functional change.
  • Code quality improvement only.

Copy link

vercel bot commented Oct 13, 2025

@jayamrutiya is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.43%. Comparing base (498e2b7) to head (0ab4091).
⚠️ Report is 85 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
+ Coverage   34.67%   39.43%   +4.76%     
==========================================
  Files         131      135       +4     
  Lines        8703     9237     +534     
==========================================
+ Hits         3018     3643     +625     
+ Misses       5685     5594      -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@dartpain dartpain merged commit 835d717 into arc53:main Oct 14, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants