WF-1621 consider live deployment #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manchicken
previously approved these changes
Sep 8, 2025
|
This is a good PR. Could you also give it the old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching all deployments, we should filter out the live-deployment, as that should never be deleted. If the live-deployment is the oldest, it would always be attempting to delete it, which would fail and thus run into the risk that clients have too many bundles, making this GA break.
Trying to find out which internal setup we have for testing this.
Tangentially related ticket, from which this originates:
https://arcpublishing.atlassian.net/browse/WF-1621