Remove led 3 and 4 from utils since they need a specific sketch

Author: mirkokurt

src/arduino/app_utils/__init__.py

@@ -12,6 +12,7 @@
 from .jsonparser import *
 from .logger import *
 from .slidingwindowbuffer import *
+from .userinput import *
 from .leds import *
 
 __all__ = [

src/arduino/app_utils/leds.py

@@ -2,68 +2,42 @@
 #
 # SPDX-License-Identifier: MPL-2.0
 
-from arduino.app_utils import Logger, Bridge
+from arduino.app_utils import Logger
 
 logger = Logger(__name__)
 
-LED_IDS = [1, 2, 3, 4]  # Supported LED IDs
-
-LED_BRIGHTNESS_FILES = [
-    "/sys/class/leds/red:user/brightness",
-    "/sys/class/leds/green:user/brightness",
-    "/sys/class/leds/blue:user/brightness",
-    "/sys/class/leds/red:panic/brightness",
-    "/sys/class/leds/green:wlan/brightness",
-    "/sys/class/leds/blue:bt/brightness",
-]
-
-
-def write_led_file(led_file, color):
-    try:
-        with open(led_file, "w") as f:
-            f.write(f"{color}\n")
-    except Exception as e:
-        print(f"Error writing to {led_file}: {e}")
-
 
 class Leds:
+    _led_ids = [1, 2]  # Supported LED IDs (Led 3 and 4 can't be controlled directly by MPU but only by MCU via Bridge)
+
+    _led1_brightness_files = [
+        "/sys/class/leds/red:user/brightness",
+        "/sys/class/leds/green:user/brightness",
+        "/sys/class/leds/blue:user/brightness",
+    ]
+    _led2_brightness_files = [
+        "/sys/class/leds/red:panic/brightness",
+        "/sys/class/leds/green:wlan/brightness",
+        "/sys/class/leds/blue:bt/brightness",
+    ]
+
     @staticmethod
-    # Led 1 and 2 are controlled by directly (MPU), while Led 3 and 4 are controlled via Bridge (MCU)
-    def set_led_color(ledid: int, rgb_color: dict):
+    def _write_led_file(led_file, value: bool):
         try:
-            if ledid not in LED_IDS:
-                raise ValueError(f"Unknown led '{ledid}'")
-
-            if not rgb_color or not all(k in rgb_color for k in ("r", "g", "b")):
-                raise ValueError("Color must be an object with 'r', 'g', 'b' keys")
-
-            match ledid:
-                case 1:
-                    Leds.set_led1_color(rgb_color["r"], rgb_color["g"], rgb_color["b"])
-                case 2:
-                    Leds.set_led2_color(rgb_color["r"], rgb_color["g"], rgb_color["b"])
-                case 3:
-                    Leds.set_led3_color(rgb_color["r"], rgb_color["g"], rgb_color["b"])
-                case 4:
-                    Leds.set_led4_color(rgb_color["r"], rgb_color["g"], rgb_color["b"])
-
+            with open(led_file, "w") as f:
+                f.write(f"{int(value)}\n")
         except Exception as e:
-            Logger(__name__).error(f"LED color set error: {e}")
+            print(f"Error writing to {led_file}: {e}")
 
     @staticmethod
-    def set_led1_color(r, g, b):
-        write_led_file(LED_BRIGHTNESS_FILES[0], r)
-        write_led_file(LED_BRIGHTNESS_FILES[1], g)
-        write_led_file(LED_BRIGHTNESS_FILES[2], b)
+    def set_led1_color(r: bool, g: bool, b: bool):
+        Leds._write_led_file(Leds._led1_brightness_files[0], r)
+        Leds._write_led_file(Leds._led1_brightness_files[1], g)
+        Leds._write_led_file(Leds._led1_brightness_files[2], b)
 
     @staticmethod
-    def set_led2_color(r, g, b):
-        write_led_file(LED_BRIGHTNESS_FILES[3], r)
-        write_led_file(LED_BRIGHTNESS_FILES[4], g)
-        write_led_file(LED_BRIGHTNESS_FILES[5], b)
-
-    def set_led3_color(r, g, b):
-        Bridge.call("set_led_color", 3, r, g, b)
+    def set_led2_color(r: bool, g: bool, b: bool):
+        Leds._write_led_file(Leds._led2_brightness_files[0], r)
+        Leds._write_led_file(Leds._led2_brightness_files[1], g)
+        Leds._write_led_file(Leds._led2_brightness_files[2], b)
 
-    def set_led4_color(r, g, b):
-        Bridge.call("set_led_color", 4, r, g, b)