-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Update repositories.txt #7186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repositories.txt #7186
Conversation
|
❌ ERROR: Arduino Lint found errors with https://github.com/atestb/MCP4151: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @atestb After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
❌ ERROR: Arduino Lint found errors with https://github.com/atestb/MCP4151-Digital-Potentiometer: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @atestb After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @atestb. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.
If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:
https://github.com/atestb/MCP4151-Digital-Potentiometer/blob/v1.0.0/library.properties#L1
name=MCP4151
❗ Remember to update the value of the version property in the library's library.properties file as needed before making a release/tag.
Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will be automatically added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of a tidy repository, I'm going to close this due to lack of activity.
@atestb if you can ever make the effort to create a tag in your repository, please submit another pull request to add the library. Next time, prior to submitting a pull request please make sure you can reserve enough time to monitor the feedback and act promptly on any changes that are required. We expect the contributors to make the effort to complete their requests rather than leaving them in an incomplete state to clutter up this busy repository and consume finite human maintenance resources. The submission procedure is trivial, well documented, and streamlined; so this is not an unreasonable expectation.
I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.
|
Hello @per1234, So now I would have bumped the version number and given the corresponding tag to my repo. So could this PR be re-openend so that maybe the bot could be reactivated? Greetings! |
|
Please check it again @ArduinoBot. |
|
Hello! I'm checking your submission again. |
|
Arduino Lint has suggestions for possible improvements to https://github.com/atestb/MCP4151-Digital-Potentiometer: |
|
❌ ERROR: Your submission meets all requirements. However, the pull request could not be merged. Please follow this guide to sync your fork: Once that is done, it will be merged automatically. |
|
Arduino Lint has suggestions for possible improvements to https://github.com/atestb/MCP4151-Digital-Potentiometer: |
|
Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index. The library(s) will be available for installation via Library Manager within a day's time. You can check the logs from the Library Manager indexer for your library(s) here: |
No description provided.