Skip to content

Conversation

@atestb
Copy link
Contributor

@atestb atestb commented Oct 30, 2025

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Oct 30, 2025
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/atestb/MCP4151:

Linting library in MCP4151
ERROR: Library name MCP4151 is in use by a library in the Library Manager index. Each library must have a unique name   
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in MCP4151/examples/FastPotentiometerValueChange

Linter results for project: no errors or warnings

-------------------

Linting sketch in MCP4151/examples/MinimalPotentiometerExample

Linter results for project: no errors or warnings

-------------------

Linting sketch in MCP4151/examples/UserPotentiometerValueInput

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @atestb
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/atestb/MCP4151-Digital-Potentiometer:

Linting library in MCP4151-Digital-Potentiometer
ERROR: Library name MCP4151 is in use by a library in the Library Manager index. Each library must have a unique name   
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in MCP4151-Digital-Potentiometer/examples/FastPotentiometerValueChange

Linter results for project: no errors or warnings

-------------------

Linting sketch in MCP4151-Digital-Potentiometer/examples/MinimalPotentiometerExample

Linter results for project: no errors or warnings

-------------------

Linting sketch in MCP4151-Digital-Potentiometer/examples/UserPotentiometerValueInput

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @atestb
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @atestb. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/atestb/MCP4151-Digital-Potentiometer/blob/v1.0.0/library.properties#L1

name=MCP4151

❗ Remember to update the value of the version property in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will be automatically added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 self-assigned this Oct 30, 2025
@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Oct 30, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of a tidy repository, I'm going to close this due to lack of activity.

@atestb if you can ever make the effort to create a tag in your repository, please submit another pull request to add the library. Next time, prior to submitting a pull request please make sure you can reserve enough time to monitor the feedback and act promptly on any changes that are required. We expect the contributors to make the effort to complete their requests rather than leaving them in an incomplete state to clutter up this busy repository and consume finite human maintenance resources. The submission procedure is trivial, well documented, and streamlined; so this is not an unreasonable expectation.

I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.

@per1234 per1234 closed this Nov 1, 2025
@atestb
Copy link
Contributor Author

atestb commented Nov 2, 2025

Hello @per1234,
sorry.
(This is one of my first workflows and in the github ecosystem,
and I wasnt aware of the tight timings involved neither.)

So now I would have bumped the version number and given the corresponding tag to my repo.
This should work out now in my opinion.

So could this PR be re-openend so that maybe the bot could be reactivated?
Or please advise how to proceed if you find the time.

Greetings!

@per1234 per1234 reopened this Nov 2, 2025
@per1234
Copy link
Contributor

per1234 commented Nov 2, 2025

Please check it again @ArduinoBot.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Nov 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/atestb/MCP4151-Digital-Potentiometer:

Linting library in MCP4151-Digital-Potentiometer
INFO: No header file found matching library name (MCP4151_Digital_Potentiometer.h). Best practices are for primary      
      header filename to match library name.                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name MCP4151 Digital Potentiometer contains spaces. Although supported, best practices is to
         not use spaces.                                                                                                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in MCP4151-Digital-Potentiometer/examples/FastPotentiometerValueChange

Linter results for project: no errors or warnings

-------------------

Linting sketch in MCP4151-Digital-Potentiometer/examples/MinimalPotentiometerExample

Linter results for project: no errors or warnings

-------------------

Linting sketch in MCP4151-Digital-Potentiometer/examples/UserPotentiometerValueInput

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to sync your fork:
https://docs.github.com/github/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Once that is done, it will be merged automatically.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/atestb/MCP4151-Digital-Potentiometer:

Linting library in MCP4151-Digital-Potentiometer
INFO: No header file found matching library name (MCP4151_Digital_Potentiometer.h). Best practices are for primary      
      header filename to match library name.                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name MCP4151 Digital Potentiometer contains spaces. Although supported, best practices is to
         not use spaces.                                                                                                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in MCP4151-Digital-Potentiometer/examples/FastPotentiometerValueChange

Linter results for project: no errors or warnings

-------------------

Linting sketch in MCP4151-Digital-Potentiometer/examples/MinimalPotentiometerExample

Linter results for project: no errors or warnings

-------------------

Linting sketch in MCP4151-Digital-Potentiometer/examples/UserPotentiometerValueInput

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit e670431 into arduino:main Nov 2, 2025
11 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/atestb/MCP4151-Digital-Potentiometer/

github-actions bot pushed a commit that referenced this pull request Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants