fix: Version override in ArgoCD CR causes operator to use upstream images #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages Signed-off-by: akhil nittala <nakhil@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
overrides the env variable if present with spec values provided by user
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-7789
Fixes #?
How to test changes / Special notes to the reviewer:
configuring Argo CD operator image via environment variable and validate the following scenarios:
No spec.image and no spec.version in the ArgoCD CR → Verify that the ArgoCD resource uses the image specified in the environment variable.
spec.version provided, but no spec.image in the ArgoCD CR → Verify that the ArgoCD resource uses the environment variable image with the user-provided tag.
Both spec.image and spec.version provided in the ArgoCD CR → Verify that the ArgoCD resource uses the user-provided image and version.