Fix string.concat and bytes.concat assignment to a constant variable.
#16341
+213
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodiazet
changed the title
string.concat and bytes.concat assignment to a constant variable.
cameel
reviewed
Dec 10, 2025
Collaborator
There was a problem hiding this comment.
type_information_pure_assignment_error.sol
I don't see any errors in this file :)
| } | ||
|
|
||
| contract A { | ||
| bytes constant aName = type(A).creationCode; |
Collaborator
There was a problem hiding this comment.
math_functions_pure_assignment_error.sol
Well, if you exclude keccak, the main common thing between them is that they are wrappers over precompiles. And due to this they might behave differently in some aspects so I'd test them as that and do keccak separately.
Collaborator
There was a problem hiding this comment.
You also have sha() there twice.
Collaborator
There was a problem hiding this comment.
We should cover also the block/tx/msg properties.
And global functions like blockhash()/blockhash().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially reviewed here #16335
This PR fixes assignment to a constant variable of a result of string or bytes concatenation, if their arguments are values known in the compile-time.
Closes: #16188
Additionally