Skip to content

v140 #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

v140 #1945

wants to merge 20 commits into from

Conversation

Thorin-Oakenpants
Copy link
Contributor

No description provided.

@Tiagoquix
Copy link
Contributor

@Thorin-Oakenpants suggestion. change the following:

user.js/user.js

Line 858 in 3d76c74

* [SETTING] Privacy & Security>Logins and Passwords>Ask to save logins and passwords for websites ***/

This one is now:

Privacy & Security>Passwords>Ask to save passwords

@Thorin-Oakenpants Thorin-Oakenpants changed the title v136 v138 Apr 18, 2025
@Thorin-Oakenpants Thorin-Oakenpants changed the title v138 v139 Jun 9, 2025
@sertonix
Copy link

Since letterboxing isn't enabled by default anymore the flip this pref comment should probably be changed.

@62f1346c-4576-42b3-afcb-23ef1820da34

user_pref("browser.startup.homepage", "about:blank");

nit: ffx uses chrome://browser/content/blanktab.html for years; is there a benefit in using about:blank instead or is it just outdated?

@Thorin-Oakenpants
Copy link
Contributor Author

user_pref("browser.startup.homepage", "about:blank");

nit: ffx uses chrome://browser/content/blanktab.html for years; is there a benefit in using about:blank instead or is it just outdated?

IDK if it really matters, but they changed it from about:blank in FF108 to the chrome:// schema in https://bugzilla.mozilla.org/show_bug.cgi?id=1676492 (AFAICT). I'll change the pref value to match - not going to read the bugzilla but I do know about:blank can load webcontent, and we can access about:blank via opener from a webpage etc - it's not always simple or clear what the principal is - perhaps this chrome:// schema is more robust/secure - but TBH, I doubt about:blank has any real issues as a landing page (nothing else can interact with it AFAIK)

@Tiagoquix
Copy link
Contributor

@Thorin-Oakenpants maybe change 0103 comment too? current wording suggests about:blank is one of the accepted values, and the new value is not on that list

@Tiagoquix
Copy link
Contributor

Tiagoquix commented Jun 30, 2025

Also I think this piece here basically makes about:blank and the chrome page the literally same thing?

https://hg-edge.mozilla.org/mozilla-central/rev/1ef480e93a6a#l7.13

(Link from the bugzilla report)

@Tiagoquix
Copy link
Contributor

Also I think this piece here basically makes about:blank and the chrome page the literally same thing?

https://hg-edge.mozilla.org/mozilla-central/rev/1ef480e93a6a#l7.13

(Link from the bugzilla report)

@Thorin-Oakenpants I think about:blank is exact the same as setting that page directly, so I think there is no benefit from complicating things, but both work fine IMO

@Thorin-Oakenpants Thorin-Oakenpants changed the title v139 v140 Jul 4, 2025
that 50GB may be a bug and is immaterial - the point is that permission is session only and not global, so users with small hard drive free space (e.g. VMs, mobile phones etc) are protected
@Tiagoquix
Copy link
Contributor

@Thorin-Oakenpants

image

how dare you call DRM "Digital Rights Management" instead of "Digital Restrictions Management"?

grr grr Stallman is angry

it's in Gibibytes, not Gigabytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants