Automatic wireless performance tests
#770
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
You can disable this status message by setting the WalkthroughThe PR updates docs/WifiPerformance.md with a new test run (Test Date updated to 2025-08-21 03:58 UTC). Measured iperf3 throughput, per-interval transfers/bitrates, wireless link metrics (frequency, RX/TX byte counts, signal, bitrates, MCS/VHT), and device forward/reverse speeds were revised. Device listing was refactored: older RTL entries removed/collapsed, new RTL88X2CS entries added, some devices removed (e.g., EDUP EP-AC1681) and others re-labeled; OS/image and NetBox image references were updated. Changes are documentation-only. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
docs/WifiPerformance.md (3)
71-74: Inline HTML triggers MD033 – prefer pure Markdown for tables
<span style="font-size: …">…</span>is only used for visual sizing and is unnecessary for conveying the data. Removing the HTML cleans up the source and appeasesmarkdownlintwithout hurting readability.-|<span style="font-size: 1.5rem;">RTL88x2BU</span> | <span style="font-size: 1.5rem;">AC</span> | <span style="font-size: 1.5rem;">152</span> Mbits/sec | <span style="font-size: 1.5rem;">272</span> Mbits/sec | +| **RTL88x2BU** | **AC** | **152 Mbits/sec** | **272 Mbits/sec** |(Apply the same pattern to other device tables.)
79-95: Suppress linter noise for verbatim iperf logs
markdownlintraises MD009 (trailing spaces) on these lines, but the spaces are part of the fixed-width iperf output. Surround the fence with an inline disable/enable to avoid false positives.+<!-- markdownlint-disable MD009 --> ```text (iperf output)+
--- `122-129`: **Micro-consistency: units appear twice** Lines 123-128 already state the field (e.g. `RX`) and then add `bytes` inside the value. Dropping the unit after the number keeps formatting consistent with other numeric fields like `freq`. </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 04657c04c0395b72802ab74bf6118fd0ef7a4159 and aff2d5f04fdc7737915bbfe1010cbd19f58dd70d. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `docs/WifiPerformance.md` (9 hunks) </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🪛 markdownlint-cli2 (0.17.2)</summary> <details> <summary>docs/WifiPerformance.md</summary> 64-64: Headings should be surrounded by blank lines Expected: 1; Actual: 0; Above (MD022, blanks-around-headings) --- 68-68: Bare URL used null (MD034, no-bare-urls) --- 69-69: Inline HTML Element: span (MD033, no-inline-html) --- 73-73: Inline HTML Element: span (MD033, no-inline-html) --- 73-73: Inline HTML Element: span (MD033, no-inline-html) --- 73-73: Inline HTML Element: span (MD033, no-inline-html) --- 73-73: Inline HTML Element: span (MD033, no-inline-html) --- 81-81: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 82-82: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 83-83: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 84-84: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 85-85: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 86-86: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 87-87: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 88-88: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 89-89: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 90-90: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 95-95: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 103-103: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 104-104: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 105-105: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 106-106: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 107-107: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 108-108: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 109-109: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 110-110: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 111-111: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 112-112: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 117-117: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 137-137: Inline HTML Element: span (MD033, no-inline-html) --- 137-137: Inline HTML Element: span (MD033, no-inline-html) --- 137-137: Inline HTML Element: span (MD033, no-inline-html) --- 137-137: Inline HTML Element: span (MD033, no-inline-html) --- 145-145: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 146-146: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 147-147: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 148-148: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 149-149: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 150-150: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 151-151: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 152-152: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 153-153: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 154-154: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 159-159: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 167-167: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 168-168: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 169-169: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 170-170: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 171-171: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 172-172: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 173-173: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 174-174: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 175-175: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 176-176: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 198-198: Inline HTML Element: span (MD033, no-inline-html) --- 198-198: Inline HTML Element: span (MD033, no-inline-html) --- 198-198: Inline HTML Element: span (MD033, no-inline-html) --- 198-198: Inline HTML Element: span (MD033, no-inline-html) --- 206-206: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 207-207: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 208-208: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 209-209: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 210-210: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 211-211: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 212-212: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 213-213: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 214-214: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 215-215: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 220-220: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 228-228: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 229-229: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 230-230: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 231-231: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 232-232: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 233-233: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 234-234: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 235-235: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 236-236: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 237-237: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 242-242: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 259-259: Inline HTML Element: span (MD033, no-inline-html) --- 259-259: Inline HTML Element: span (MD033, no-inline-html) --- 259-259: Inline HTML Element: span (MD033, no-inline-html) --- 259-259: Inline HTML Element: span (MD033, no-inline-html) --- 267-267: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 268-268: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 269-269: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 270-270: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 271-271: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 272-272: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 273-273: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 274-274: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 275-275: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 276-276: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 281-281: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 289-289: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 290-290: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 291-291: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 292-292: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 293-293: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 294-294: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 295-295: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 296-296: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 297-297: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 298-298: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 303-303: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 324-324: Inline HTML Element: span (MD033, no-inline-html) --- 324-324: Inline HTML Element: span (MD033, no-inline-html) --- 324-324: Inline HTML Element: span (MD033, no-inline-html) --- 324-324: Inline HTML Element: span (MD033, no-inline-html) --- 332-332: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 333-333: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 334-334: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 335-335: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 336-336: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 337-337: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 338-338: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 339-339: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 340-340: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 341-341: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 346-346: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 354-354: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 355-355: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 356-356: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 357-357: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 358-358: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 359-359: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 360-360: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 361-361: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 362-362: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 363-363: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 368-368: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 389-389: Inline HTML Element: span (MD033, no-inline-html) --- 389-389: Inline HTML Element: span (MD033, no-inline-html) --- 389-389: Inline HTML Element: span (MD033, no-inline-html) --- 389-389: Inline HTML Element: span (MD033, no-inline-html) --- 397-397: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 398-398: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 399-399: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 400-400: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 401-401: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 402-402: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 403-403: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 404-404: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 405-405: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 406-406: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 411-411: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 419-419: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 420-420: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 421-421: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 422-422: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 423-423: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 424-424: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 425-425: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 426-426: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 427-427: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 428-428: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 433-433: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 454-454: Inline HTML Element: span (MD033, no-inline-html) --- 454-454: Inline HTML Element: span (MD033, no-inline-html) --- 454-454: Inline HTML Element: span (MD033, no-inline-html) --- 454-454: Inline HTML Element: span (MD033, no-inline-html) --- 462-462: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 463-463: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 464-464: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 465-465: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 466-466: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 467-467: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 468-468: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 469-469: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 470-470: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 471-471: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 476-476: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 484-484: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 485-485: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 486-486: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 487-487: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 488-488: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 489-489: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 490-490: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 491-491: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 492-492: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 493-493: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 498-498: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 513-513: Bare URL used null (MD034, no-bare-urls) --- 514-514: Inline HTML Element: span (MD033, no-inline-html) --- 518-518: Inline HTML Element: span (MD033, no-inline-html) --- 518-518: Inline HTML Element: span (MD033, no-inline-html) --- 518-518: Inline HTML Element: span (MD033, no-inline-html) --- 518-518: Inline HTML Element: span (MD033, no-inline-html) --- 526-526: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 527-527: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 528-528: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 529-529: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 530-530: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 531-531: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 532-532: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 533-533: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 534-534: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 535-535: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 540-540: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 548-548: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 549-549: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 550-550: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 551-551: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 552-552: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 553-553: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 554-554: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 555-555: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 556-556: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 557-557: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 562-562: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 582-582: Inline HTML Element: span (MD033, no-inline-html) --- 582-582: Inline HTML Element: span (MD033, no-inline-html) --- 582-582: Inline HTML Element: span (MD033, no-inline-html) --- 582-582: Inline HTML Element: span (MD033, no-inline-html) --- 590-590: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 591-591: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 592-592: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 593-593: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 594-594: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 595-595: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 596-596: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 597-597: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 598-598: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 599-599: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 604-604: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 612-612: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 613-613: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 614-614: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 615-615: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 616-616: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 617-617: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 618-618: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 619-619: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 620-620: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 621-621: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 626-626: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 646-646: Inline HTML Element: span (MD033, no-inline-html) --- 646-646: Inline HTML Element: span (MD033, no-inline-html) --- 646-646: Inline HTML Element: span (MD033, no-inline-html) --- 646-646: Inline HTML Element: span (MD033, no-inline-html) --- 654-654: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 655-655: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 656-656: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 657-657: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 658-658: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 659-659: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 660-660: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 661-661: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 662-662: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 663-663: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 668-668: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 676-676: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 677-677: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 678-678: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 679-679: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 680-680: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 681-681: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 682-682: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 683-683: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 684-684: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 685-685: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 690-690: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 705-705: Bare URL used null (MD034, no-bare-urls) --- 706-706: Inline HTML Element: span (MD033, no-inline-html) --- 710-710: Inline HTML Element: span (MD033, no-inline-html) --- 710-710: Inline HTML Element: span (MD033, no-inline-html) --- 710-710: Inline HTML Element: span (MD033, no-inline-html) --- 710-710: Inline HTML Element: span (MD033, no-inline-html) --- 718-718: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 719-719: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 720-720: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 721-721: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 722-722: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 723-723: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 724-724: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 725-725: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 726-726: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 727-727: Trailing spaces Expected: 0 or 2; Actual: 18 (MD009, no-trailing-spaces) --- 732-732: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) --- 740-740: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 741-741: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 742-742: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 743-743: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 744-744: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 745-745: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 746-746: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 747-747: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 748-748: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 749-749: Trailing spaces Expected: 0 or 2; Actual: 7 (MD009, no-trailing-spaces) --- 754-754: Trailing spaces Expected: 0 or 2; Actual: 4 (MD009, no-trailing-spaces) </details> </details> </details> <details> <summary>🔇 Additional comments (2)</summary><blockquote> <details> <summary>docs/WifiPerformance.md (2)</summary> `61-64`: **Timestamp hyperlink is a helpful traceability win** Linking the test date (line 63) directly to the workflow run is a neat touch that short-cuts anyone who needs to audit raw artefacts. --- `387-390`: **Throughput drop warrants a quick re-check** `MT7921AU` forward average is now 114 Mbps versus ~300 Mbps in the previous run. If this isn’t an expected regression (e.g. antenna change, AP load), it might be worth rerunning the test before publishing. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
armbianworker
force-pushed
the
wireless-tests
branch
from
aff2d5f to
557f576
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (7)
docs/WifiPerformance.md (7)
61-62: Grammar: “Devices Under Tests” → “Devices Under Test”Minor grammar fix in the section heading.
-## Devices Under Tests +## Devices Under Test
687-691: Minor grammar and style fixes for clarity and consistency
- Use “has” instead of “have”.
- “defined” instead of “define”.
- Prefer “e.g.” and add “the” for clarity.
-Each site have devices such as Access Points (APs), iperf3 servers, and wireless test clients. +Each site has devices such as Access Points (APs), iperf3 servers, and wireless test clients. @@ - Make sure to check if site is not already define to not clutter database! + Make sure to check if the site is not already defined to avoid cluttering the database! @@ -- Set hostname that reflects wireless test device (eg. rtl3070, wifiserver) +- Set the hostname that reflects the wireless test device (e.g., rtl3070, wifiserver)Also applies to: 693-695, 609-610
719-728: Tag correctness: “USB Wireless” likely inaccurate for Compex WLE900VX (PCIe)This example uses “Tags: USB Wireless”, but Compex WLE900VX (QCA9880) is a PCIe card. Suggest using a tag that matches the bus/class (e.g., “PCI Wireless”).
- - Tags: USB Wireless + - Tags: PCI Wireless
311-317: Consistency: unify frequency format (integer vs float)“freq: 5500.0” is the only float; others are integers (e.g., 5500). Suggest normalizing for cleaner diffs across runs.
- freq: 5500.0 + freq: 5500
73-73: markdownlint MD033: inline HTML spans in tablesInline HTML is flagged by markdownlint. Options:
- Remove spans and use plain text (simplest).
- Or bracket with markdownlint disable/enable comments if larger font is required.
Option A: Remove spans (example for one row; repeat similarly across the file)
-|<span style="font-size: 1.5rem;">BCM4345</span> | <span style="font-size: 1.5rem;">AC</span> | <span style="font-size: 1.5rem;">223</span> Mbits/sec | <span style="font-size: 1.5rem;">266</span> Mbits/sec | +| BCM4345 | AC | 223 Mbits/sec | 266 Mbits/sec |Option B: Disable MD033 locally (around specific lines)
+<!-- markdownlint-disable MD033 --> |<span style="font-size: 1.5rem;">BCM4345</span> | <span style="font-size: 1.5rem;">AC</span> | <span style="font-size: 1.5rem;">223</span> Mbits/sec | <span style="font-size: 1.5rem;">266</span> Mbits/sec | +<!-- markdownlint-enable MD033 -->Also applies to: 138-138, 202-202, 262-262, 327-327, 392-392, 457-457, 517-517
253-253: markdownlint MD022: headings must be surrounded by blank linesHeadings “### AX” and “### N” are flagged. Ensure a blank line before these headings. Removing the empty “Wireless link info” block above AX (see earlier comment) will also satisfy MD022. If not removing, add a blank line above the headings.
-``` -### AX +``` + +### AX(similarly for “### N”)
Also applies to: 318-318
68-71: Unquoted HTML attribute values and baretags
The
tags use unquoted src values and trigger MD033 (inline HTML). Consider:
- Converting to Markdown images:
- Or keep
but quote attributes to be HTML-standards-friendly and wrap with markdownlint disable comments if needed.
Example conversion:
-<img src=https://stuff.armbian.com/netbox/media/devicetype-images/BCM4345.png> +Or keep
and quote:
-<img src=https://stuff.armbian.com/netbox/media/devicetype-images/BCM4345.png> +<img src="https://stuff.armbian.com/netbox/media/devicetype-images/BCM4345.png">Also applies to: 133-137, 197-201, 257-261, 322-326, 387-391, 452-456, 512-516
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/WifiPerformance.md(6 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/WifiPerformance.md
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
81-81: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
82-82: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
83-83: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
84-84: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
85-85: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
86-86: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
87-87: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
88-88: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
89-89: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
90-90: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
95-95: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
103-103: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
104-104: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
105-105: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
106-106: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
107-107: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
108-108: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
109-109: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
110-110: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
111-111: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
112-112: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
117-117: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
146-146: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
147-147: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
148-148: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
149-149: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
150-150: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
151-151: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
152-152: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
153-153: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
154-154: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
155-155: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
160-160: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
168-168: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
169-169: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
170-170: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
171-171: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
172-172: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
173-173: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
174-174: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
175-175: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
176-176: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
177-177: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
182-182: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
202-202: Inline HTML
Element: span
(MD033, no-inline-html)
202-202: Inline HTML
Element: span
(MD033, no-inline-html)
202-202: Inline HTML
Element: span
(MD033, no-inline-html)
202-202: Inline HTML
Element: span
(MD033, no-inline-html)
210-210: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
211-211: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
212-212: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
213-213: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
214-214: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
215-215: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
216-216: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
217-217: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
218-218: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
219-219: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
224-224: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
232-232: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
233-233: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
234-234: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
235-235: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
236-236: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
237-237: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
238-238: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
239-239: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
240-240: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
241-241: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
246-246: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
253-253: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Above
(MD022, blanks-around-headings)
257-257: Bare URL used
(MD034, no-bare-urls)
258-258: Inline HTML
Element: span
(MD033, no-inline-html)
262-262: Inline HTML
Element: span
(MD033, no-inline-html)
262-262: Inline HTML
Element: span
(MD033, no-inline-html)
262-262: Inline HTML
Element: span
(MD033, no-inline-html)
262-262: Inline HTML
Element: span
(MD033, no-inline-html)
270-270: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
271-271: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
272-272: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
273-273: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
274-274: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
275-275: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
276-276: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
277-277: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
278-278: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
279-279: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
284-284: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
292-292: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
293-293: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
294-294: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
295-295: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
296-296: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
297-297: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
298-298: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
299-299: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
300-300: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
301-301: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
306-306: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
318-318: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Above
(MD022, blanks-around-headings)
322-322: Bare URL used
(MD034, no-bare-urls)
323-323: Inline HTML
Element: span
(MD033, no-inline-html)
327-327: Inline HTML
Element: span
(MD033, no-inline-html)
327-327: Inline HTML
Element: span
(MD033, no-inline-html)
327-327: Inline HTML
Element: span
(MD033, no-inline-html)
327-327: Inline HTML
Element: span
(MD033, no-inline-html)
335-335: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
336-336: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
337-337: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
338-338: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
339-339: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
340-340: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
341-341: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
342-342: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
343-343: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
344-344: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
349-349: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
357-357: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
358-358: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
359-359: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
360-360: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
361-361: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
362-362: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
363-363: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
364-364: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
365-365: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
366-366: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
371-371: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
392-392: Inline HTML
Element: span
(MD033, no-inline-html)
392-392: Inline HTML
Element: span
(MD033, no-inline-html)
392-392: Inline HTML
Element: span
(MD033, no-inline-html)
392-392: Inline HTML
Element: span
(MD033, no-inline-html)
400-400: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
401-401: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
402-402: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
403-403: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
404-404: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
405-405: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
406-406: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
407-407: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
408-408: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
409-409: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
414-414: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
422-422: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
423-423: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
424-424: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
425-425: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
426-426: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
427-427: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
428-428: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
429-429: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
430-430: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
431-431: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
436-436: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
457-457: Inline HTML
Element: span
(MD033, no-inline-html)
457-457: Inline HTML
Element: span
(MD033, no-inline-html)
457-457: Inline HTML
Element: span
(MD033, no-inline-html)
457-457: Inline HTML
Element: span
(MD033, no-inline-html)
465-465: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
466-466: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
467-467: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
468-468: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
469-469: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
470-470: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
471-471: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
472-472: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
473-473: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
474-474: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
479-479: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
487-487: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
488-488: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
489-489: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
490-490: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
491-491: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
492-492: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
493-493: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
494-494: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
495-495: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
496-496: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
501-501: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
512-512: Bare URL used
(MD034, no-bare-urls)
513-513: Inline HTML
Element: span
(MD033, no-inline-html)
517-517: Inline HTML
Element: span
(MD033, no-inline-html)
517-517: Inline HTML
Element: span
(MD033, no-inline-html)
517-517: Inline HTML
Element: span
(MD033, no-inline-html)
517-517: Inline HTML
Element: span
(MD033, no-inline-html)
525-525: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
526-526: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
527-527: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
528-528: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
529-529: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
530-530: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
531-531: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
532-532: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
533-533: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
534-534: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
539-539: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
547-547: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
548-548: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
549-549: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
550-550: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
551-551: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
552-552: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
553-553: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
554-554: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
555-555: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
556-556: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
561-561: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
🔇 Additional comments (3)
docs/WifiPerformance.md (3)
185-193: 2.4 GHz link info with an AC-class device (QCA9880) looks inconsistentWireless link info shows freq: 2437 MHz (2.4 GHz) for an 802.11ac-class device (which is 5 GHz only). Please verify the band used or whether this DUT ran in 11n mode. If it’s 2.4 GHz, consider classifying the run accordingly or clarifying mode/band in the tab.
63-63: Good: Test date links to the exact GitHub Actions runLinking the test date to the run ID makes results auditable. Nice touch.
81-90: Trailing whitespace removed in docs/WifiPerformance.mdAll trailing spaces have been stripped from the iperf3 output blocks in
docs/WifiPerformance.md, so markdownlint MD009 should no longer report any errors. CI will now pass without further changes.
armbianworker
force-pushed
the
wireless-tests
branch
from
557f576 to
410cdb7
Compare
armbianworker
force-pushed
the
wireless-tests
branch
from
410cdb7 to
510c716
Compare
armbianworker
force-pushed
the
wireless-tests
branch
from
510c716 to
26db10d
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
docs/WifiPerformance.md (2)
75-101: Swap mislabeled Forward/Reverse tabs for BCM4345The “Forward mode (client to server)” tab contains iperf3 output that explicitly indicates “Reverse mode … is sending,” and the “Reverse mode” tab lacks that banner. Headings and content are swapped.
Apply this diff to correct the tab labels:
-=== "Forward mode (client to server)" +=== "Reverse mode (server to client)" ``` Connecting to host 10.0.60.10, port 5201 - Reverse mode, remote host 10.0.60.10 is sending + Reverse mode, remote host 10.0.60.10 is sending [ 5] local 10.0.50.180 port 49183 connected to 10.0.60.10 port 5201 ... iperf Done. ``` -=== "Reverse mode (server to client)" +=== "Forward mode (client to server)" ``` Connecting to host 10.0.60.10, port 5201 [ 5] local 10.0.50.180 port 48407 connected to 10.0.60.10 port 5201 ... iperf Done. ```Also applies to: 98-120
140-167: Swap mislabeled Forward/Reverse tabs for QCA9880 (Compex WLE900VX)Same issue as above: “Forward mode” tab shows “Reverse mode” banner; headings are inverted.
Apply this diff:
-=== "Forward mode (client to server)" +=== "Reverse mode (server to client)" ``` Connecting to host 10.0.60.10, port 5201 - Reverse mode, remote host 10.0.60.10 is sending + Reverse mode, remote host 10.0.60.10 is sending [ 5] local 10.0.50.179 port 47985 connected to 10.0.60.10 port 5201 ... iperf Done. ``` -=== "Reverse mode (server to client)" +=== "Forward mode (client to server)" ``` Connecting to host 10.0.60.10, port 5201 [ 5] local 10.0.50.179 port 40355 connected to 10.0.60.10 port 5201 ... iperf Done. ```Also applies to: 163-185
🧹 Nitpick comments (4)
docs/WifiPerformance.md (4)
81-95: Trim trailing spaces in code blocks to satisfy markdownlint (MD009)Trailing spaces are present on many iperf3 output lines, flagged by markdownlint-cli2 MD009. Please strip them (ideally in the generator).
Representative fix for the shown ranges:
- [ 5] 0.00-1.00 sec 26.2 MBytes 220 Mbits/sec + [ 5] 0.00-1.00 sec 26.2 MBytes 220 Mbits/sec - [ 5] 1.00-2.00 sec 24.8 MBytes 208 Mbits/sec + [ 5] 1.00-2.00 sec 24.8 MBytes 208 Mbits/sec - [ 5] 2.00-3.00 sec 26.6 MBytes 223 Mbits/sec + [ 5] 2.00-3.00 sec 26.6 MBytes 223 Mbits/sec - [ 5] 3.00-4.00 sec 27.1 MBytes 227 Mbits/sec + [ 5] 3.00-4.00 sec 27.1 MBytes 227 Mbits/sec - [ 5] 4.00-5.00 sec 26.7 MBytes 224 Mbits/sec + [ 5] 4.00-5.00 sec 26.7 MBytes 224 Mbits/sec - [ 5] 5.00-6.00 sec 27.2 MBytes 228 Mbits/sec + [ 5] 5.00-6.00 sec 27.2 MBytes 228 Mbits/sec - [ 5] 6.00-7.00 sec 26.9 MBytes 226 Mbits/sec + [ 5] 6.00-7.00 sec 26.9 MBytes 226 Mbits/sec - [ 5] 7.00-8.00 sec 26.8 MBytes 225 Mbits/sec + [ 5] 7.00-8.00 sec 26.8 MBytes 225 Mbits/sec - [ 5] 8.00-9.00 sec 26.6 MBytes 223 Mbits/sec + [ 5] 8.00-9.00 sec 26.6 MBytes 223 Mbits/sec - [ 5] 9.00-10.00 sec 26.9 MBytes 226 Mbits/sec + [ 5] 9.00-10.00 sec 26.9 MBytes 226 Mbits/sec ... - [ 5] 0.00-1.00 sec 33.9 MBytes 284 Mbits/sec 0 953 KBytes + [ 5] 0.00-1.00 sec 33.9 MBytes 284 Mbits/sec 0 953 KBytes - [ 5] 1.00-2.00 sec 30.0 MBytes 252 Mbits/sec 3 749 KBytes + [ 5] 1.00-2.00 sec 30.0 MBytes 252 Mbits/sec 3 749 KBytes ... - [ 5] 0.00-1.00 sec 12.0 MBytes 101 Mbits/sec + [ 5] 0.00-1.00 sec 12.0 MBytes 101 Mbits/sec ... - [ 5] 0.00-1.00 sec 11.6 MBytes 97.1 Mbits/sec 0 417 KBytes + [ 5] 0.00-1.00 sec 11.6 MBytes 97.1 Mbits/sec 0 417 KBytesIf these blocks are autogenerated, ensure your emitter right-strips each line (e.g., rstrip()) before writing.
Also applies to: 103-117, 146-160, 168-182
71-74: Address markdownlint MD033 for inline HTML in tablesInline HTML is flagged. Either replace spans or suppress MD033 locally.
Two viable approaches:
- Minimal suppression for the affected rows:
+<!-- markdownlint-disable-next-line MD033 --> | Chipset | Class | Average forward speed | Average reverse speed | |:-----|------|-------:|-------:| |<span style="font-size: 1.5rem;">BCM4345</span> | <span style="font-size: 1.5rem;">AC</span> | <span style="font-size: 1.5rem;">225</span> Mbits/sec | <span style="font-size: 1.5rem;">263</span> Mbits/sec |
- Or remove spans and rely on plain Markdown emphasis (simpler, no linter suppression), e.g.:
-|<span style="font-size: 1.5rem;">BCM4345</span> | <span style="font-size: 1.5rem;">AC</span> | <span style="font-size: 1.5rem;">225</span> Mbits/sec | <span style="font-size: 1.5rem;">263</span> Mbits/sec | +| BCM4345 | AC | 225 Mbits/sec | 263 Mbits/sec |Apply the same for the QCA9880 row.
Also applies to: 136-139
122-127: Add units to frequency for clarityThe frequency values lack units; add “MHz” to avoid ambiguity.
- freq: 5500 + freq: 5500 MHz ... - freq: 2437 + freq: 2437 MHzAlso applies to: 187-193
61-63: Grammar: “Devices Under Tests” → “Devices Under Test”Minor wording fix in the section heading.
-## Devices Under Tests +## Devices Under Test
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/WifiPerformance.md(3 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/WifiPerformance.md
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
81-81: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
82-82: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
83-83: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
84-84: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
85-85: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
86-86: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
87-87: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
88-88: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
89-89: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
90-90: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
95-95: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
103-103: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
104-104: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
105-105: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
106-106: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
107-107: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
108-108: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
109-109: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
110-110: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
111-111: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
112-112: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
117-117: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
146-146: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
147-147: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
148-148: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
149-149: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
150-150: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
151-151: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
152-152: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
153-153: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
154-154: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
155-155: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
160-160: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
168-168: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
169-169: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
170-170: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
171-171: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
172-172: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
173-173: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
174-174: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
175-175: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
176-176: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
177-177: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
182-182: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
🔇 Additional comments (1)
docs/WifiPerformance.md (1)
63-63: LGTM: Updated test date and run linkThe test date and Actions run reference look good and clearly anchor the dataset.
armbianworker
force-pushed
the
wireless-tests
branch
from
26db10d to
b5b205f
Compare
armbianworker
force-pushed
the
wireless-tests
branch
from
b5b205f to
876868a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
docs/WifiPerformance.md (2)
75-98: Forward/Reverse tabs are swapped vs iperf3 logsIn each “Forward mode (client to server)” tab, the embedded iperf3 output starts with “Reverse mode, remote host … is sending,” which indicates a reverse (-R) run. Conversely, the “Reverse mode (server to client)” tabs do not show the reverse banner. Please swap the tab headings or move the code blocks so labels align with the logs. If autogenerated, fix the generator mapping.
As an example, for the BCM4345 block, simply swap the tab labels:
-=== "Forward mode (client to server)" +=== "Reverse mode (server to client)" ``` Connecting to host 10.0.60.10, port 5201 Reverse mode, remote host 10.0.60.10 is sending ... ``` -=== "Reverse mode (server to client)" +=== "Forward mode (client to server)" ``` Connecting to host 10.0.60.10, port 5201 ... ```Repeat for the other devices in this file.
Also applies to: 100-119, 140-163, 164-184, 204-227, 228-248, 263-286, 287-307
249-252: Empty “Wireless link info” block — populate or removeThis tab is empty, which is confusing. Either render “N/A” placeholders or omit the tab for this device.
Option A (placeholders):
=== "Wireless link info" ``` - + freq: N/A + RX: N/A + TX: N/A + signal: N/A + rx bitrate: N/A + tx bitrate: N/A ```Option B (remove the tab):
-=== "Wireless link info" - ``` - - ```</blockquote></details> </blockquote></details> <details> <summary>🧹 Nitpick comments (5)</summary><blockquote> <details> <summary>docs/WifiPerformance.md (5)</summary><blockquote> `185-193`: **Add missing tx bitrate (or N/A) for consistency** Other devices show both rx and tx bitrates. Add a tx bitrate line or explicit N/A to keep the schema consistent. Apply this diff: ```diff rx bitrate: 144.4 MBit/s MCS 15 short GI + tx bitrate: N/A
81-90: Resolve markdownlint MD009 (trailing spaces in iperf logs)The fenced iperf3 outputs contain trailing spaces, triggering MD009. Prefer trimming trailing spaces in the generator when capturing logs. If preserving exact spacing is desired, disable MD009 for this file or around iperf blocks.
Two approaches:
- Disable relevant rules at file scope (minimal churn):
--- comments: true --- +# markdownlint-disable MD009 MD033 MD034
- Trim trailing spaces in generated code blocks (recommended) — update the generator to rstrip each line before writing.
Also applies to: 103-112, 146-155, 168-177, 210-219, 232-241, 269-278, 291-300
73-73: Inline HTML spans trigger MD033; decide policy (disable or replace)The tables use to enlarge text. If that styling is required, disable MD033; otherwise, replace with plain Markdown.
If you want to keep HTML, add this at the top (combined with MD009/MD034 disable as above):
+# markdownlint-disable MD009 MD033 MD034Or replace spans with plain Markdown (smaller visual impact):
-|<span style="font-size: 1.5rem;">BCM4345</span> | <span style="font-size: 1.5rem;">AC</span> | <span style="font-size: 1.5rem;">49.6</span> Mbits/sec | <span style="font-size: 1.5rem;">53.4</span> Mbits/sec | +|**BCM4345** | **AC** | **49.6** Mbits/sec | **53.4** Mbits/sec |Also applies to: 138-138, 202-202, 261-261
197-198: Replace bareURLs with Markdown image syntax (MD034)
Converting to Markdown image syntax avoids MD034 and is consistent with the rest of the doc.
Apply these diffs:
-<img src=https://stuff.armbian.com/netbox/media/devicetype-images/RTL8821CU.png> +-<img src=https://stuff.armbian.com/netbox/media/devicetype-images/RTL88X2CS.png> +If you prefer to keep raw
, disable MD034 at file scope as suggested earlier.
Also applies to: 256-257
462-471: Tighten “Register Device” example to avoid cross-device confusionThe example mixes a commercial name “Compex WLE900VX” with device type “AIC8800” and tag “USB Wireless” (but WLE900VX is PCIe). Consider using a single, coherent example or placeholder tokens to avoid misconfiguration by readers.
Proposed wording:
- Name:
- Device role: WiFi DUT
- Tags: USB Wireless | PCI Wireless | SDIO (pick one)
- Manufacturer: Generic
- Device type: (e.g., WLE900VX)
- Serial number:
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/WifiPerformance.md(3 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/WifiPerformance.md
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
81-81: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
82-82: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
83-83: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
84-84: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
85-85: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
86-86: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
87-87: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
88-88: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
89-89: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
90-90: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
95-95: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
103-103: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
104-104: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
105-105: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
106-106: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
107-107: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
108-108: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
109-109: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
110-110: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
111-111: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
112-112: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
117-117: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
146-146: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
147-147: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
148-148: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
149-149: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
150-150: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
151-151: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
152-152: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
153-153: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
154-154: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
155-155: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
160-160: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
168-168: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
169-169: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
170-170: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
171-171: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
172-172: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
173-173: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
174-174: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
175-175: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
176-176: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
177-177: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
182-182: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
192-192: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
197-197: Bare URL used
(MD034, no-bare-urls)
198-198: Inline HTML
Element: span
(MD033, no-inline-html)
202-202: Inline HTML
Element: span
(MD033, no-inline-html)
202-202: Inline HTML
Element: span
(MD033, no-inline-html)
202-202: Inline HTML
Element: span
(MD033, no-inline-html)
202-202: Inline HTML
Element: span
(MD033, no-inline-html)
210-210: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
211-211: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
212-212: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
213-213: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
214-214: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
215-215: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
216-216: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
217-217: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
218-218: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
219-219: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
224-224: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
232-232: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
233-233: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
234-234: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
235-235: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
236-236: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
237-237: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
238-238: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
239-239: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
240-240: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
241-241: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
246-246: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
256-256: Bare URL used
(MD034, no-bare-urls)
257-257: Inline HTML
Element: span
(MD033, no-inline-html)
261-261: Inline HTML
Element: span
(MD033, no-inline-html)
261-261: Inline HTML
Element: span
(MD033, no-inline-html)
261-261: Inline HTML
Element: span
(MD033, no-inline-html)
261-261: Inline HTML
Element: span
(MD033, no-inline-html)
269-269: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
270-270: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
271-271: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
272-272: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
273-273: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
274-274: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
275-275: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
276-276: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
277-277: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
278-278: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
283-283: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
291-291: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
292-292: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
293-293: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
294-294: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
295-295: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
296-296: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
297-297: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
298-298: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
299-299: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
300-300: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
305-305: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
🪛 LanguageTool
docs/WifiPerformance.md
[grammar] ~197-~197: There might be a mistake here.
Context: ...x/media/devicetype-images/RTL8821CU.png> OS: Arm...
(QB_NEW_EN)
[grammar] ~200-~200: There might be a mistake here.
Context: ... forward speed | Average reverse speed | |:-----|------|-------:|-------:| |<span...
(QB_NEW_EN)
[grammar] ~201-~201: There might be a mistake here.
Context: ...peed | |:-----|------|-------:|-------:| |RTL882...
(QB_NEW_EN)
[grammar] ~249-~249: There might be a mistake here.
Context: ...f Done. === "Wireless link info" ``` #### Realtek 88X2CS <img ...
(QB_NEW_EN)
[grammar] ~256-~256: There might be a mistake here.
Context: ...x/media/devicetype-images/RTL88X2CS.png> OS: Arm...
(QB_NEW_EN)
[grammar] ~259-~259: There might be a mistake here.
Context: ... forward speed | Average reverse speed | |:-----|------|-------:|-------:| |<span...
(QB_NEW_EN)
[grammar] ~260-~260: There might be a mistake here.
Context: ...peed | |:-----|------|-------:|-------:| |RTL88X...
(QB_NEW_EN)
🔇 Additional comments (1)
docs/WifiPerformance.md (1)
63-63: Verify the GitHub Actions run linkConfirm the run ID 17097046373 is accessible and corresponds to this test set; otherwise update the link.
Would you like me to scan the repo for the latest successful wireless-performance-autotest run and update this reference automatically?
| @@ -60,7 +60,7 @@ All wireless adapters were tested under consistent conditions - each positioned | |||
|
|
|||
| ## Devices Under Tests | |||
There was a problem hiding this comment.
Fix heading grammar: “Devices Under Test” (singular “Test”)
Correct the section header for clarity and professionalism.
Apply this diff:
-## Devices Under Tests
+## Devices Under Test📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## Devices Under Tests | |
| ## Devices Under Test |
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
61-61: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
🤖 Prompt for AI Agents
In docs/WifiPerformance.md around line 61, the section heading currently reads
"## Devices Under Tests"; change it to "## Devices Under Test" (singular "Test")
to correct grammar and professionalism by replacing "Tests" with "Test" on that
line.
876868a to
1652087
Compare
armbianworker
force-pushed
the
wireless-tests
branch
from
1652087 to
9fc6f58
Compare
armbianworker
force-pushed
the
wireless-tests
branch
from
9fc6f58 to
9cf58c0
Compare
armbianworker
force-pushed
the
wireless-tests
branch
from
9cf58c0 to
f131308
Compare
armbianworker
force-pushed
the
wireless-tests
branch
from
f131308 to
bb7d1ee
Compare
armbianworker
force-pushed
the
wireless-tests
branch
from
bb7d1ee to
c53f9ce
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
docs/WifiPerformance.md (3)
249-252: Empty “Wireless link info” block — populate or remove.This fenced block is empty, which is confusing. Either provide placeholders or omit the tab. Example with placeholders:
=== "Wireless link info" ``` - + freq: N/A + RX: N/A + TX: N/A + signal: N/A + rx bitrate: N/A + tx bitrate: N/A ```
75-98: Swap mislabeled Forward/Reverse tabs to match iperf3 logs.Each “Forward mode (client to server)” block starts with iperf3’s “Reverse mode, remote host … is sending” banner, which indicates a reverse (-R) run. Conversely, the “Reverse mode (server to client)” blocks lack that banner and show sender-side TCP stats (Retr/Cwnd), characteristic of forward runs. This mislabeling is misleading.
Apply the following header swaps:
-=== "Forward mode (client to server)" +=== "Reverse mode (server to client)" ... -=== "Reverse mode (server to client)" +=== "Forward mode (client to server)"Concrete changes:
@@ 75 @@ -=== "Forward mode (client to server)" +=== "Reverse mode (server to client)" @@ 98 @@ -=== "Reverse mode (server to client)" +=== "Forward mode (client to server)" @@ 140 @@ -=== "Forward mode (client to server)" +=== "Reverse mode (server to client)" @@ 163 @@ -=== "Reverse mode (server to client)" +=== "Forward mode (client to server)" @@ 204 @@ -=== "Forward mode (client to server)" +=== "Reverse mode (server to client)" @@ 227 @@ -=== "Reverse mode (server to client)" +=== "Forward mode (client to server)" @@ 263 @@ -=== "Forward mode (client to server)" +=== "Reverse mode (server to client)" @@ 286 @@ -=== "Reverse mode (server to client)" +=== "Forward mode (client to server)" @@ 328 @@ -=== "Forward mode (client to server)" +=== "Reverse mode (server to client)" @@ 351 @@ -=== "Reverse mode (server to client)" +=== "Forward mode (client to server)"If these sections are auto-generated, please fix the generator to file each iperf3 run under the correct tab based on the “Reverse mode” banner. I can provide a small parser to classify blocks automatically if helpful.
Also applies to: 98-120, 140-163, 163-184, 204-227, 227-248, 263-286, 286-307, 328-351, 351-372
61-62: Fix heading grammar and add required blank line.Correct pluralization and satisfy markdownlint MD022 (blank line below heading).
-## Devices Under Tests -This section presents the performance test results, including key metrics and technical details from the test execution. +## Devices Under Test + +This section presents the performance test results, including key metrics and technical details from the test execution.
🧹 Nitpick comments (5)
docs/WifiPerformance.md (5)
310-316: Standardize frequency format and units.Use integer MHz with unit for consistency (other blocks show plain integers without units; prefer “MHz” everywhere).
- freq: 2437.0 + freq: 2437 MHzWould you like me to sweep the file (or the generator) to render all “freq” values as “ MHz” consistently?
1-4: Silence markdownlint for unavoidable constructs (inline HTML, trailing spaces in logs, bare URLs).The doc intentionally uses inline HTML for sizing inside tables and preserves iperf3 log spacing; markdownlint flags these (MD033, MD009, MD034). Disable these rules at file scope to avoid noisy CI failures without altering content fidelity.
--- comments: true --- +<!-- markdownlint-disable MD009 MD033 MD034 -->Optionally re-enable at the end of the file:
- (EOF) +<!-- markdownlint-enable MD009 MD033 MD034 -->If you prefer to keep linting strict, I can instead provide a script to trim trailing spaces inside code fences and replace with markdown-safe alternatives.
25-25: Verify workflow links and naming consistency.Two different workflow paths are referenced:
- Line 25: wireless-performance-autotest.yml
- Lines 550–551: wireless-performance-autotest.yml (OK) but earlier sections and “Contribute” mention usb-wireless-autotest.yml elsewhere in this repo’s docs.
Confirm both workflow filenames/locations are correct and current across armbian/armbian.github.io. If only one is canonical, align all references.
I can check and submit a follow-up PR to harmonize the links once you confirm the intended workflow name.
Also applies to: 550-551
73-73: Inline HTML in tables (font-size spans).These spans trigger MD033 but are otherwise harmless. If you keep them for emphasis, rely on the global markdownlint disable above. If not, drop the spans and keep plain text.
Example (for one row):
-|<span style="font-size: 1.5rem;">BCM4345</span> | <span style="font-size: 1.5rem;">AC</span> | <span style="font-size: 1.5rem;">51.4</span> Mbits/sec | <span style="font-size: 1.5rem;">50.5</span> Mbits/sec | +| BCM4345 | AC | 51.4 Mbits/sec | 50.5 Mbits/sec |Also applies to: 138-139, 202-203, 261-262, 326-327
75-98: Optional: add language hint to iperf3 code blocks.Use “text” or “console” fences for better readability and tooling.
- ``` + ```text Connecting to host 10.0.60.10, port 5201 Reverse mode, remote host 10.0.60.10 is sending ... - ``` + ```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/WifiPerformance.md(6 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/WifiPerformance.md
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
73-73: Inline HTML
Element: span
(MD033, no-inline-html)
81-81: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
82-82: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
83-83: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
84-84: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
85-85: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
86-86: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
87-87: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
88-88: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
89-89: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
90-90: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
95-95: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
103-103: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
104-104: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
105-105: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
106-106: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
107-107: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
108-108: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
109-109: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
110-110: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
111-111: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
112-112: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
117-117: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
138-138: Inline HTML
Element: span
(MD033, no-inline-html)
146-146: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
147-147: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
148-148: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
149-149: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
150-150: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
151-151: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
152-152: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
153-153: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
154-154: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
155-155: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
160-160: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
168-168: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
169-169: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
170-170: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
171-171: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
172-172: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
173-173: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
174-174: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
175-175: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
176-176: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
177-177: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
182-182: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
192-192: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
197-197: Bare URL used
(MD034, no-bare-urls)
198-198: Inline HTML
Element: span
(MD033, no-inline-html)
202-202: Inline HTML
Element: span
(MD033, no-inline-html)
202-202: Inline HTML
Element: span
(MD033, no-inline-html)
202-202: Inline HTML
Element: span
(MD033, no-inline-html)
202-202: Inline HTML
Element: span
(MD033, no-inline-html)
210-210: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
211-211: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
212-212: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
213-213: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
214-214: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
215-215: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
216-216: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
217-217: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
218-218: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
219-219: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
224-224: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
232-232: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
233-233: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
234-234: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
235-235: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
236-236: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
237-237: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
238-238: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
239-239: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
240-240: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
241-241: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
256-256: Bare URL used
(MD034, no-bare-urls)
257-257: Inline HTML
Element: span
(MD033, no-inline-html)
261-261: Inline HTML
Element: span
(MD033, no-inline-html)
261-261: Inline HTML
Element: span
(MD033, no-inline-html)
261-261: Inline HTML
Element: span
(MD033, no-inline-html)
261-261: Inline HTML
Element: span
(MD033, no-inline-html)
269-269: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
270-270: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
271-271: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
272-272: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
273-273: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
274-274: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
275-275: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
276-276: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
277-277: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
278-278: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
283-283: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
291-291: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
292-292: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
293-293: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
294-294: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
295-295: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
296-296: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
297-297: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
298-298: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
299-299: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
300-300: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
305-305: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
326-326: Inline HTML
Element: span
(MD033, no-inline-html)
326-326: Inline HTML
Element: span
(MD033, no-inline-html)
326-326: Inline HTML
Element: span
(MD033, no-inline-html)
326-326: Inline HTML
Element: span
(MD033, no-inline-html)
334-334: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
335-335: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
336-336: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
337-337: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
338-338: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
339-339: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
340-340: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
341-341: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
342-342: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
343-343: Trailing spaces
Expected: 0 or 2; Actual: 18
(MD009, no-trailing-spaces)
348-348: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
356-356: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
357-357: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
358-358: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
359-359: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
360-360: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
361-361: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
362-362: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
363-363: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
364-364: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
365-365: Trailing spaces
Expected: 0 or 2; Actual: 7
(MD009, no-trailing-spaces)
370-370: Trailing spaces
Expected: 0 or 2; Actual: 4
(MD009, no-trailing-spaces)
🪛 LanguageTool
docs/WifiPerformance.md
[grammar] ~197-~197: There might be a mistake here.
Context: ...x/media/devicetype-images/RTL8821CU.png> OS: Arm...
(QB_NEW_EN)
[grammar] ~200-~200: There might be a mistake here.
Context: ... forward speed | Average reverse speed | |:-----|------|-------:|-------:| |<span...
(QB_NEW_EN)
[grammar] ~201-~201: There might be a mistake here.
Context: ...peed | |:-----|------|-------:|-------:| |RTL882...
(QB_NEW_EN)
[grammar] ~256-~256: There might be a mistake here.
Context: ...x/media/devicetype-images/RTL88X2CS.png> OS: Arm...
(QB_NEW_EN)
[grammar] ~259-~259: There might be a mistake here.
Context: ... forward speed | Average reverse speed | |:-----|------|-------:|-------:| |<span...
(QB_NEW_EN)
[grammar] ~260-~260: There might be a mistake here.
Context: ...peed | |:-----|------|-------:|-------:| |RTL88X...
(QB_NEW_EN)
[grammar] ~395-~395: There might be a mistake here.
Context: ... N | | Realtek 8811AU | RTL8812AU | AC | | Realtek 8812AU | RTL8812AU | AC | | Re...
(QB_NEW_EN)
[grammar] ~396-~396: There might be a mistake here.
Context: ...AC | | Realtek 8812AU | RTL8812AU | AC | | Realtek 8814AU | RTL8814AU | AC | | Re...
(QB_NEW_EN)
| | Realtek 8811AU | RTL8812AU | AC | | ||
| | Realtek 8812AU | RTL8812AU | AC | |
There was a problem hiding this comment.
Correct chip mappings for Realtek 8811AU/8812AU.
The “Chip” column mismatches the commercial name.
-| Realtek 8811AU | RTL8812AU | AC |
-| Realtek 8812AU | RTL8812AU | AC |
+| Realtek 8811AU | RTL8811AU | AC |
+| Realtek 8812AU | RTL8812AU | AC |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| | Realtek 8811AU | RTL8812AU | AC | | |
| | Realtek 8812AU | RTL8812AU | AC | | |
| | Realtek 8811AU | RTL8811AU | AC | | |
| | Realtek 8812AU | RTL8812AU | AC | |
🧰 Tools
🪛 LanguageTool
[grammar] ~395-~395: There might be a mistake here.
Context: ... N | | Realtek 8811AU | RTL8812AU | AC | | Realtek 8812AU | RTL8812AU | AC | | Re...
(QB_NEW_EN)
[grammar] ~396-~396: There might be a mistake here.
Context: ...AC | | Realtek 8812AU | RTL8812AU | AC | | Realtek 8814AU | RTL8814AU | AC | | Re...
(QB_NEW_EN)
🤖 Prompt for AI Agents
In docs/WifiPerformance.md around lines 395-396, the table rows for Realtek
8811AU/8812AU have the wrong chip mapping: change the chip value for the Realtek
8811AU row from RTL8812AU to RTL8811AU, and verify the Realtek 8812AU row
remains mapped to RTL8812AU so the commercial names correctly match their chip
identifiers.
armbianworker
force-pushed
the
wireless-tests
branch
from
c53f9ce to
1a6a63c
Compare
Generate documentation.
Documentation website preview will be available shortly:
Open WWW preview