build#8785 - mmdebstrap

[tabrisnet]

see armbian/build#8785, documentation for LEGACY_DEBOOTSTRAP

[coderabbitai]

Walkthrough

This change updates docs/Developer-Guide_Build-Switches.md to add a new build switch named LEGACY_DEBOOTSTRAP (boolean). When set, the documented behavior selects debootstrap as the bootstrap tool; otherwise the documentation indicates mmdebstrap is used. The change is limited to documentation and does not modify exported or public code entities.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title Check	❓ Inconclusive	The title "build#8785 - mmdebstrap" references the main aspect of the change (mmdebstrap bootstrapping) and the related issue number, but relies on external context to be understood. While mmdebstrap is central to what the PR documents (the LEGACY_DEBOOTSTRAP build switch choice between debootstrap and mmdebstrap), the title does not clearly explain that this is documentation for a new build switch. A reader without familiarity with the referenced issue would struggle to understand the purpose from the title alone.	Consider revising the title to be more descriptive and self-contained, such as "Document LEGACY_DEBOOTSTRAP build switch option" or "Add documentation for mmdebstrap vs debootstrap bootstrap selection". This would make the purpose of the change immediately clear without requiring knowledge of the referenced issue.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	The pull request description explicitly states "documentation for LEGACY_DEBOOTSTRAP", which directly aligns with the changeset that adds documentation for the new LEGACY_DEBOOTSTRAP build switch. The description clearly indicates the purpose of the PR and what is being documented, making it directly related to the changes being made in the documentation file.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 30b3a83 and d3f0e8a.

📒 Files selected for processing (1)

• docs/Developer-Guide_Build-Switches.md (1 hunks)

🔇 Additional comments (1)

docs/Developer-Guide_Build-Switches.md (1)

393-393: Documentation format is clear and consistent.

The new LEGACY_DEBOOTSTRAP option follows the established documentation pattern for hidden advanced options: clear parameter naming, explicit type annotation, options listed, and default marked in bold. The description concisely explains the behavior (choose between debootstrap or mmdebstrap). Placement in the "Hidden options for advanced users" section is appropriate.

Before merging, please confirm that the documented behavior—where yes selects debootstrap and no (default) selects mmdebstrap—accurately reflects the implementation in the Armbian build system.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}