Web content embeddings [LAB-18] #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor search params [LAB-11]
…uccessful import [LAB-13]
…rd search [LAB-11]
…d of a copy [LAB-13]
…ing since the classes already define a connection [LAB-13]
…red console trait [LAB-13]
…)` method [LAB-11]
…earch-in-es Add vector search to general keyword searches [LAB-11]
…te-embeddings-on-import Regenerate embeddings on artwork import [LAB-13]
…e for `image` [LAB-13]
…boost-behavior-in-search Adjust boost behavior in search [LAB-16]
…ey-fallbacks Fix api error for unmapped keys
…ost-route-for-visually-similar-2 Create endpoint for posting images and searching nearest image neighbor [LAB-19]
zachgarwood
requested changes
Jun 10, 2025
| $this->info("Saved text embeddings", OutputInterface::VERBOSITY_VERBOSE); | ||
| } catch (\Exception $e) { | ||
| throw new Exception("Failed to save text embeddings: " . $e->getMessage()); | ||
| } |
There was a problem hiding this comment.
This try-catch inside a try-catch seems redundant.
| } | ||
| }); | ||
|
|
||
| usleep($this->sleepFor * 10000); |
There was a problem hiding this comment.
In the ImportsData trait, it says that $sleepFor is "Seconds to sleep between requests" but here we're only sleeping for 10 milliseconds (10,000 microseconds = 10 milliseconds). For clarity, maybe we should use the Laravel Sleep helper, for example:
use Illuminate\Support\Sleep;
protected $sleepFor = 1 / 100; // 0.01 seconds or 10 milliseconds
Sleep::for($sleepFor)->seconds();There was a problem hiding this comment.
For reference: https://laravel.com/docs/10.x/helpers#sleep
nikhiltri
force-pushed
the
feature/web-content-embeddings
branch
from
ebc0fc1 to
ae06694
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.