Logging Behavior #15
Open
Logging Behavior #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmoudkandeel
approved these changes
Jan 28, 2021
rafek1241
suggested changes
May 19, 2021
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "UseInMemoryDatabase": false, | |||
| "UseInMemoryDatabase": true, | |||
| services.AddMediatR(Assembly.GetExecutingAssembly()); | ||
| //services.AddTransient(typeof(IPipelineBehavior<,>), typeof(ValidationBehavior<,>)); | ||
| services.AddTransient(typeof(IPipelineBehavior<,>), typeof(LoggingBehaviour<,>)); | ||
|
|
There was a problem hiding this comment.
Additionaly I'm not sure that is proper place to do it. There could be more suitable place.
For an example create method like below:
public static void AddMediatr(this IServiceCollcetion services){
services.AddMediatr(Assembly...
services.AddTransient(typeof(IPipelineBehavior....
}and use it in AddApplicationLayer method instead of line 16. (services.AddMediatr...)
| public AuthenticatedUserService(IHttpContextAccessor httpContextAccessor) | ||
| { | ||
| UserId = httpContextAccessor.HttpContext?.User?.FindFirstValue("uid"); | ||
| Username = httpContextAccessor.HttpContext?.User?.FindFirstValue(ClaimTypes.NameIdentifier); |
There was a problem hiding this comment.
Not related to the logging behavior. Should be commited in separate PR.
| @@ -1,4 +1,5 @@ | |||
| using AspNetCoreHero.Boilerplate.Application.Interfaces.Repositories; | |||
| using AspNetCoreHero.Boilerplate.Application.Exceptions; | |||
| var requestName = typeof(TRequest).Name; | ||
| try | ||
| { | ||
| _logger.LogInformation("{Name} Request From User {UserId}-{UserName}", requestName, _authenticatedUserService.UserId, _authenticatedUserService.Username); |
There was a problem hiding this comment.
I would use _logger.LogDebug( because it can be very big amount of data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.