Fix: correct regex for bigint OpenAPI pattern #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additionally, a bigint type with no default() appears as a random value in schema example value. I am unable to find out how this is generated. Ideally it should be "0".
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to ensure proper escaping of backslashes in regular expressions for bigint patterns. The changes affect both the test cases and the transformer logic.
Changes to regular expression escaping:
spec/types/bigint.spec.ts: Updated the test case for theSimpleBigIntschema to use a properly escaped regular expression (^\d+) for thepattern` property.src/transformers/big-int.ts: Modified theBigIntTransformerclass to use the escaped regular expression (^\d+) in thepattern` property when transforming a nullable type.