-
-
Notifications
You must be signed in to change notification settings - Fork 112
chore: get Fran back as maintainer #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
That's brilliant dude! For some reason no PR is able to be merged. Like THIS ONE #1094 More on #1094 (comment) |
|
Damn, I haven't landed as a maintainer yet and you're already giving me work to do 😅 Let me check 👀 |
|
The impossibility to merge PRs is due to the failing Puppeteer test. There is no required by Puppeteer software installed by default in GitHub's All non-merged PRs were going through testing on As a possible solution, this test can be removed from the NPM test script so that it doesn't run as part of the regular tests, and a separate workflow can be created that runs exclusively the Puppeteer test. This workflow can run on just one VM, and it can even be a macOS, as this test is not OS-specific. |
a87872d
|
magicmatatjahu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome back! 👋
|
/rtm |
|
@fmvilas Welcome back mate! 😃 |



Description
I'm back...
Related issue(s)
Fixes #1097