WIP: Fix integer usage and API #1880
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
force-pushed
the
fix-int-usage
branch
2 times, most recently
from
138be64 to
2b9e045
Compare
Add functions that are specific to int32 and int64 and less error prone. These functions have been introduced after big integers introduction in order to avoid bugs (since previous functions were more error prone). Signed-off-by: Davide Bettio <davide@uninstall.it>
Add a function for converting the uint64_t special case. Support for int32_t and int64_t was already there, but also uint64_t can be reppresented using 2 digits. The newly introduce predicate also counts digits so input doesn't have to be normalized. Signed-off-by: Davide Bettio <davide@uninstall.it>
uint32_t and uint64_t are widely common when dealing with low level features such as peripherals. So, add new functions to avoid possible bugs with quite common usages. Signed-off-by: Davide Bettio <davide@uninstall.it>
Functions such as `term_is_any_integer` return true also with big integers, but `term_maybe_unbox_int` and other similar functions will return garbage if such a big integer term is used as an argument. Fix existing code in order to avoid bugs, using newly introduced `term_is_(u)int32/(u)int64` and `term_to_(u)int32/(u)int64`. Signed-off-by: Davide Bettio <davide@uninstall.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pattern it might return garbage now:
term_is_any_integer(t)andterm_is_boxed_integer(t)are true also for big integers, so in some situations the API might return garbage, since there are no specific APIs.Introduce new APIs for handling the most common integer types.
Continuation of #1863
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later