Skip to content

Conversation

@cleoold
Copy link

@cleoold cleoold commented Aug 12, 2024

Changes

Allow passing sandbox to the hidden iframe when using renewAuth(). This is desired when it's not necessary to execute javascript code in the iframe if all what's wanted is to extract url hash as soon as the page is returned:

renewAuth({ usePostMessage: false, sandbox: 'allow-same-origin' }, e => {});

It is also a security measure to tighten the resources which can be accessed. The default value here is "allow-same-origin allow-scripts", which should ensure most of the existing scenarios work.

References

NA

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant