Skip to content

Conversation

RonenMars
Copy link
Contributor

@RonenMars RonenMars commented Oct 5, 2025

Description

New E2E Test Suite: triggerSyncResponse.spec.ts

Comprehensive test coverage including:

  • ✅ Create trigger with Synchronous Response enabled/disabled
  • ✅ Modify trigger to enable/disable Synchronous Response
  • ✅ State persistence after navigation
  • ✅ Compatibility with Durability toggle
  • ✅ Edit mode visibility
  • ✅ Active deployment preservation
  • ✅ Description visibility

Test Improvements

  • Extracted acknowledgeDeploymentWarning() helper function to project.ts

Linear Ticket

What type of PR is this? (check all applicable)

  • 💡 (feat) - A new feature (non-breaking change which adds functionality)
  • 🔄 (refactor) - Code Refactoring - A code change that neither fixes a bug nor adds a feature
  • 🐞 (fix) - Bug Fix (non-breaking change which fixes an issue)
  • 🏎 (perf) - Optimization
  • 📄 (docs) - Documentation - Documentation only changes
  • 📄 (test) - Tests - Adding missing tests or correcting existing tests
  • ⚙️ (ci) - Continuous Integrations - Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • ☑️ (chore) - Chores - Other changes that don't modify src or test files
  • ↩️ (revert) - Reverts - Reverts a previous commit(s).

@RonenMars RonenMars requested a review from itayd October 5, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant