no gosec in test files

Author: JonathanOppenheimer

.avalanche-golangci.yml

@@ -244,3 +244,12 @@ linters:
       - common-false-positives
       - legacy
       - std-error-handling
+    rules:
+      # Exclude some linters from running on test files.
+      # 1. Exclude the top level tests/ directory.
+      # 2. Exclude any file prefixed with test_ in any directory.
+      # 3. Exclude any directory suffixed with test.
+      # 4. Exclude any file suffixed with _test.go.
+      - path: "(^tests/)|(^(.*/)*test_[^/]*\\.go$)|(.*test/.*)|(.*_test\\.go$)"
+        linters:
+          - gosec

core/extstate/database_test.go

@@ -311,7 +311,7 @@ func (fs *fuzzState) deleteStorage(accountIndex int, storageIndexInput uint64) {
 func FuzzTree(f *testing.F) {
 	f.Fuzz(func(t *testing.T, randSeed int64, byteSteps []byte) {
 		fuzzState := newFuzzState(t)
-		rand := rand.New(rand.NewSource(randSeed)) //nolint:gosec // this isn't a good fuzz test, but it is reproducible.
+		rand := rand.New(rand.NewSource(randSeed)) // this isn't a good fuzz test, but it is reproducible.
 
 		for range 10 {
 			fuzzState.createAccount()

network/peer_tracker.go

@@ -123,14 +123,15 @@ func (p *peerTracker) GetAnyPeer(minVersion *version.Application) (ids.NodeID, b
 		averager safemath.Averager
 	)
 	randomValue, err := rand.SecureFloat64()
-	if err != nil {
+	switch {
+	case err != nil:
 		log.Error("failed to generate secure random number for peer selection", "err", err)
 		// Fallback to deterministic behavior - use bandwidth heap
 		nodeID, averager, ok = p.bandwidthHeap.Pop()
-	} else if randomValue < randomPeerProbability {
+	case randomValue < randomPeerProbability:
 		random = true
 		nodeID, averager, ok = p.getResponsivePeer()
-	} else {
+	default:
 		nodeID, averager, ok = p.bandwidthHeap.Pop()
 	}
 	if ok {

plugin/evm/atomic/atomictest/tx.go

@@ -150,7 +150,7 @@ func GenerateTestExportTx() *atomic.Tx {
 }
 
 func NewTestTx() *atomic.Tx {
-	txType := rand.Intn(2) //nolint:gosec
+	txType := rand.Intn(2)
 	switch txType {
 	case 0:
 		return GenerateTestImportTx()

plugin/evm/atomic/sync/syncer_test.go

@@ -68,7 +68,7 @@ func TestSyncerScenarios(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			r := rand.New(rand.NewSource(1)) //nolint:gosec
+			r := rand.New(rand.NewSource(1))
 			targetHeight := 10 * uint64(testCommitInterval)
 			serverTrieDB := triedb.NewDatabase(rawdb.NewMemoryDatabase(), nil)
 			root, _, _ := statesynctest.GenerateTrie(t, r, serverTrieDB, int(targetHeight), state.TrieKeyLength)
@@ -104,7 +104,7 @@ func TestSyncerResumeScenarios(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			r := rand.New(rand.NewSource(1)) //nolint:gosec
+			r := rand.New(rand.NewSource(1))
 			targetHeight := 10 * uint64(testCommitInterval)
 			serverTrieDB := triedb.NewDatabase(rawdb.NewMemoryDatabase(), nil)
 			numTrieKeys := int(targetHeight) - 1 // no atomic ops for genesis
@@ -148,7 +148,7 @@ func TestSyncerResumeNewRootCheckpointScenarios(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			r := rand.New(rand.NewSource(1)) //nolint:gosec
+			r := rand.New(rand.NewSource(1))
 			targetHeight1 := 10 * uint64(testCommitInterval)
 			serverTrieDB := triedb.NewDatabase(rawdb.NewMemoryDatabase(), nil)
 			numTrieKeys1 := int(targetHeight1) - 1 // no atomic ops for genesis
@@ -220,7 +220,7 @@ func TestSyncerContextCancellation(t *testing.T) {
 // It returns the context, mock client, atomic backend, client DB, and root hash for testing.
 func setupParallelizationTest(t *testing.T, targetHeight uint64) (context.Context, *syncclient.TestClient, *state.AtomicBackend, *versiondb.Database, common.Hash) {
 	// Create a simple test trie with some data.
-	r := rand.New(rand.NewSource(1)) //nolint:gosec
+	r := rand.New(rand.NewSource(1))
 	serverTrieDB := triedb.NewDatabase(rawdb.NewMemoryDatabase(), nil)
 	root, _, _ := statesynctest.GenerateTrie(t, r, serverTrieDB, int(targetHeight), state.TrieKeyLength)
 

plugin/evm/message/block_request_test.go

@@ -39,7 +39,7 @@ func TestMarshalBlockRequest(t *testing.T) {
 // ensure compatibility with the network.
 func TestMarshalBlockResponse(t *testing.T) {
 	// Create some random bytes and then set the seed to ensure deterministic behaviour
-	rand := rand.New(rand.NewSource(1)) //nolint:gosec
+	rand := rand.New(rand.NewSource(1))
 	blocksBytes := make([][]byte, 32)
 	for i := range blocksBytes {
 		blocksBytes[i] = make([]byte, rand.Intn(32)+32) // min 32 length, max 64

plugin/evm/message/code_request_test.go

@@ -35,7 +35,7 @@ func TestMarshalCodeRequest(t *testing.T) {
 // ensure compatibility with the network.
 func TestMarshalCodeResponse(t *testing.T) {
 	// Create some random bytes and then set the seed to ensure deterministic behaviour
-	rand := rand.New(rand.NewSource(1)) //nolint:gosec
+	rand := rand.New(rand.NewSource(1))
 
 	codeData := make([]byte, 50)
 	_, err := rand.Read(codeData)

plugin/evm/message/leafs_request_test.go

@@ -16,7 +16,7 @@ import (
 // ensure compatibility with the network.
 func TestMarshalLeafsRequest(t *testing.T) {
 	// Create some random bytes and then set the seed to ensure deterministic behaviour
-	rand := rand.New(rand.NewSource(1)) //nolint:gosec
+	rand := rand.New(rand.NewSource(1))
 
 	startBytes := make([]byte, common.HashLength)
 	endBytes := make([]byte, common.HashLength)
@@ -55,7 +55,7 @@ func TestMarshalLeafsRequest(t *testing.T) {
 // ensure compatibility with the network.
 func TestMarshalLeafsResponse(t *testing.T) {
 	// Create some random bytes and then set the seed to ensure deterministic behaviour
-	rand := rand.New(rand.NewSource(1)) //nolint:gosec
+	rand := rand.New(rand.NewSource(1))
 
 	keysBytes := make([][]byte, 16)
 	valsBytes := make([][]byte, 16)

plugin/evm/vmtest/test_syncervm.go

@@ -312,7 +312,7 @@ func initSyncServerAndClientVMs(t *testing.T, test SyncTestParams, numBlocks int
 	generateAndAcceptBlocks(t, serverVM, numBlocks, testSetup.GenFn, nil, cb)
 
 	// make some accounts
-	r := rand.New(rand.NewSource(1)) //nolint:gosec
+	r := rand.New(rand.NewSource(1))
 	root, accounts := statesynctest.FillAccountsWithOverlappingStorage(t, r, serverVM.Ethereum().BlockChain().TrieDB(), types.EmptyRootHash, 1000, 16)
 
 	// patch serverVM's lastAcceptedBlock to have the new root

sync/client/client_test.go

@@ -374,7 +374,7 @@ func buildGetter(blocks []*types.Block) handlers.BlockProvider {
 
 func TestGetLeafs(t *testing.T) {
 	const leafsLimit = 1024
-	r := rand.New(rand.NewSource(1)) //nolint:gosec
+	r := rand.New(rand.NewSource(1))
 
 	trieDB := triedb.NewDatabase(rawdb.NewMemoryDatabase(), nil)
 	largeTrieRoot, largeTrieKeys, _ := statesynctest.GenerateTrie(t, r, trieDB, 100_000, common.HashLength)
@@ -684,7 +684,7 @@ func TestGetLeafs(t *testing.T) {
 }
 
 func TestGetLeafsRetries(t *testing.T) {
-	r := rand.New(rand.NewSource(1)) //nolint:gosec
+	r := rand.New(rand.NewSource(1))
 	trieDB := triedb.NewDatabase(rawdb.NewMemoryDatabase(), nil)
 	root, _, _ := statesynctest.GenerateTrie(t, r, trieDB, 100_000, common.HashLength)