[ci] Remove use of run_env with run-monitored-tmpnet-cmd #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasks executed in CI are intended to internalize their env vars and arguments to ensure that such a task can be executed directly (e.g. `task my-task-ci`) without having to figure out the incantation used in CI (e.g. `VAR=foo task my-task-ci arg1=bar arg2=baz`). This minimize the friction required to reproduce a CI job locally. The run_env argument will also be removed from the run-monitored-tmpnet-cmd custom action defined in avalanchego to avoid accidental use going forward.
maru-ava
force-pushed
the
marun/ci-remove-run-env
branch
from
ee1b53e to
ff7759b
Compare
JonathanOppenheimer
approved these changes
Sep 22, 2025
|
I've chosen to isolate the avalanchego clone to the coreth clone (i.e. at |
maru-ava
force-pushed
the
marun/ci-remove-run-env
branch
3 times, most recently
from
6665458 to
8a2d247
Compare
alarso16
approved these changes
Sep 23, 2025
JonathanOppenheimer
pushed a commit
that referenced
this pull request
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
tasks executed in CI are intended to internalize their env vars and arguments to ensure that such a task can be executed directly (e.g.
task my-task-ci) without having to figure out the incantation used in CI (e.g.VAR=foo task my-task-ci arg1=bar arg2=baz). This minimize the friction required to reproduce a CI job locally.The run_env argument will also be removed from the run-monitored-tmpnet-cmd custom action defined in avalanchego to avoid accidental use going forward.
Update: avalanchego PR removing run_env ava-labs/avalanchego#4314
How this was tested
CI
Need to be documented?
N/A
Need to update RELEASES.md?
N/A