Skip to content

Conversation

JonathanOppenheimer
Copy link
Member

@JonathanOppenheimer JonathanOppenheimer commented Oct 17, 2025

Why this should be merged

This closes #813:

The shell script ./scripts/lint_allowed_eth_imports.sh is getting rather complex and hard to understand, we should migrate it to use Go as a test, especially now that we have getDependencies code which can easily be adapted for this use case.

I was unable to adapt the getDependencies() function to work properly with ignoring _ imports and imports that start with eth, but I did massively improve the test, and this now catches some imports that the shell script did not.

I will remove getDependencies() in the next PR anyway.

Sample:

Screenshot 2025-10-20 at 11 58 32 AM

How this works

How this was tested

The new TestLibevmImportsAreAllowed test

Need to be documented?

No

Need to update RELEASES.md?

No

@JonathanOppenheimer JonathanOppenheimer self-assigned this Oct 17, 2025
@JonathanOppenheimer JonathanOppenheimer requested a review from a team as a code owner October 17, 2025 18:16
@JonathanOppenheimer JonathanOppenheimer added the testing Anything testing-related label Oct 17, 2025
@JonathanOppenheimer
Copy link
Member Author

This is blocked by #1349 and #1350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Anything testing-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement lint_allowed_eth_imports.sh in Go

1 participant