Convert import script to a go test #1348
Open
+127
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This closes #813:
I was unable to adapt the
getDependencies()
function to work properly with ignoring_
imports and imports that start witheth
, but I did massively improve the test, and this now catches some imports that the shell script did not.I will remove
getDependencies()
in the next PR anyway.Sample:
How this works
How this was tested
The new
TestLibevmImportsAreAllowed
testNeed to be documented?
No
Need to update RELEASES.md?
No