forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 5
refactor!: temporary extras require proof of global lock #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
reviewed
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly questions
ceyonur
reviewed
Oct 13, 2025
ceyonur
reviewed
Oct 13, 2025
ceyonur
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The
temporary.WithTempRegisteredExtras()global lock introduced in #234 wasn't fit for purpose when used incorethas it required central coordination of registration, types, and usage of the payload accessor.How this works
Instead of a central registration point, the new
libevm.WithTemporaryExtrasLock()function takes out a global lock and provides the caller with a handle that proves the lock is held. All of the override functions, e.g.params.WithTempRegisteredExtras()now require a current lock, which will be propagated by the respectivecorethfunctions.See ava-labs/coreth#1328 for intended usage in
corethandsubnet-evm. A consumer of both of these can then safely do the following:How this was tested
Unit test of the new function plus existing integration tests of all modified code.