Skip to content

Conversation

@JonathanOppenheimer
Copy link
Member

@JonathanOppenheimer JonathanOppenheimer commented Oct 29, 2025

Why this should be merged

This is the first phase of the npm to Go testing migration. It adds native solc compilation and Go binding generation while
maintaining existing Hardhat-based TypeScript tests.

This PR

  • Add OpenZeppelin contracts as git submodule
  • Add contracts/compile.go with solc compilation directives
  • Add contracts/bindings/bindings.go with abigen directives
  • Update CI to install solc via setup-solc@v0.2.0
  • Update Taskfile.yml to run both Hardhat and solc compilation
  • Update .gitignore to exclude generated artifacts and bindings
  • Update contracts/README.md with new compilation instructions

How this was tested

This just needs to run successfully in CI, it doesn't directly impact tests yet

Need to be documented?

Yes, done

Need to update RELEASES.md?

No

@JonathanOppenheimer JonathanOppenheimer self-assigned this Oct 29, 2025
@JonathanOppenheimer JonathanOppenheimer requested review from a team and maru-ava as code owners October 29, 2025 21:51
@JonathanOppenheimer JonathanOppenheimer added ci testing This primarly focuses on testing labels Oct 29, 2025
ARR4N
ARR4N previously requested changes Oct 30, 2025
JonathanOppenheimer and others added 3 commits October 30, 2025 10:38
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
JonathanOppenheimer and others added 3 commits October 30, 2025 11:26
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
@ARR4N ARR4N enabled auto-merge October 31, 2025 16:47
@ARR4N ARR4N added this pull request to the merge queue Nov 3, 2025
Merged via the queue into master with commit 65f4d47 Nov 3, 2025
13 checks passed
@ARR4N ARR4N deleted the JonathanOppenheimer/convert-npm-to-go branch November 3, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci testing This primarly focuses on testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants