Fix #1504: Display appropriate error messages for common errors #1505
+3,935
−3,514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrors like server unavailable and 403 access denied
|
bro did ur changes get merged? |
Author
|
not yet
…On Fri, Jun 6, 2025 at 3:20 PM aksh-sush ***@***.***> wrote:
*aksh-sush* left a comment (avniproject/avni-webapp#1505)
<#1505 (comment)>
bro did ur changes get merged?
—
Reply to this email directly, view it on GitHub
<#1505 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM57F6EGCFN3M6COHVYTZNT3CFP75AVCNFSM6AAAAAB55JF2JWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNBYG4YDIMBZGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ombhardwajj
force-pushed
the
master
branch
7 times, most recently
from
2b98263 to
cafa6d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #1504: Display appropriate error messages for common errors
Changes Made
I've implemented user-friendly error messaging for common HTTP errors instead of showing the generic "oops" screen.
Implementation Details:
getUserFriendlyErrorMessagemethod inErrorMessageUtil.jsthat provides specific messages for different error typeshttpClient.jsto use this method for both fetch and axios requestsErrorFallback.jsto display the user-friendly error title and messageSpecific Error Handling Added:
Testing:
I was able to test the implementation and confirm it correctly displays user-friendly error messages as shown in the attached screenshot.
This improves the user experience by providing clear information about what went wrong and suggesting possible actions instead of showing a generic error screen.