-
Notifications
You must be signed in to change notification settings - Fork 124
Issue is #1578 (Navigation to report card show view is broken) is been fixed #1580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughReformatted three variable declarations inside Changes
Sequence Diagram(s)(No sequence diagram: change is purely formatting/indentation with no control-flow or feature modification.) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/formDesigner/components/ReportCard/ReportCardList.jsx(1 hunks)
🧰 Additional context used
🪛 Biome (2.1.2)
src/formDesigner/components/ReportCard/ReportCardList.jsx
[error] 7-7: Shouldn't redeclare 'useNavigate'. Consider to delete it or rename it.
'useNavigate' is defined here:
(lint/suspicious/noRedeclare)
🔇 Additional comments (1)
src/formDesigner/components/ReportCard/ReportCardList.jsx (1)
10-10: Good fix for the navigation issue.The initialization of
navigateusinguseNavigate()on line 10 and its usage on line 22 correctly addresses the broken navigation to the report card show view. Once the duplicate import on line 7 is removed, this will resolve issue #1578.Also applies to: 22-22
Root cause for this issue is we had not defined the navigate and not import it. I solved this issue #1578.Is there any thing wrong let me know it.
Summary by CodeRabbit