Fix. OpenMRSLoginAuthenticator to read JESESSIONID from cookie #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petmongrels
reviewed
Jun 2, 2023
petmongrels
left a comment
petmongrels
left a comment
There was a problem hiding this comment.
Perhaps this can be implemented by making a check on whether the session id is present in the response and if not then extract it from the cookie?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
With latest OpenMRS upgrade and upgrade of webservices rest module, the
/ws/rest/v1/sessionendpoint does not return sessionId in the body. Instead it should be read from the cookie. This fixes it by reading and extracting it from the cookie.This may not be an immediate merge for product, unless you move to latest versions of Bahmni