feat(gen2-migration): add stateful resource validation for safe migrations #14297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-ray
changed the title
Closed
2 tasks
iliapolo
approved these changes
Oct 28, 2025
iankhou
pushed a commit
that referenced
this pull request
Oct 28, 2025
…tions (#14297) * chore: scaffolding migration * chore: add gen2 migration stateful resources validations and unit tests * chore: update gen2 migration validations to use AWS SDK v3 --------- Co-authored-by: Eli Polonsky <epolon@amazon.com> Co-authored-by: Sai Ray <saisujit@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR implements stateful resource validation to prevent accidental data loss during Gen 1 to Gen 2 migrations for
refactoranddecommissioncommands. The implementation adds astateful-resources.tsfile that defines stateful resource types. ThevalidateStatefulResources()method analyzes CloudFormation changesets and throws aDestructiveMigrationErrorwhen stateful resources are scheduled for deletion, providing clear messaging about affected resources. The@aws-sdk/client-cloudformationdependency has been added to support changeset analysis.Issue #, if available
N/A
Description of how you validated changes
Added unit tests covering multiple scenarios:
All tests pass successfully, validating that the implementation correctly allows safe operations (add/modify any resources, remove stateless resources) while blocking destructive operations (remove stateful resources).
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.