-
Notifications
You must be signed in to change notification settings - Fork 820
refactor: category notifications/sdk v3 migration #14299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n stacks are stuck - Add failure predicate to treat _IN_PROGRESS states as failed after timeout - Reduce timeout to 15 minutes to fail faster on stuck operations - Prevents Jest worker processes from being killed due to hanging deletions
- Add sendEof() to In-App Messaging case to prevent hanging processes - Add notifications-analytics-compatibility-in-app-2.test.ts to RUN_SOLO to prevent Jest worker memory issues
…LL test to RUN_SOLO
ShadowCat567
approved these changes
Oct 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can you run e2es on this one last time?
svidgen
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: start notifications category migration
refactor: migrate pinpoint-helper to sdk v3
refactor: migrate channel handlers to sdk v3
refactor: migrate auth-helper to sdk v3
refactor: update test mocks for sdk v3
refactor: migrate cli logout command to sdk v3
refactor: migrate e2e-core pinpoint utils to sdk v3
fix: update package dependencies
fix: correct client import names
fix: yarn lock updates
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.