Fix Cognito Auth endpoints mapping #6475
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-dovire
force-pushed
the
fix/auth-endpoints-complete-mapping
branch
from
4a1df7f to
0bf1039
Compare
nathan-dovire
changed the title
nathan-dovire
force-pushed
the
fix/auth-endpoints-complete-mapping
branch
from
b79d900 to
83b9733
Compare
|
Hi @nathan-dovire , Thank you for your contribution to the AWS Amplify Flutter Library! Is there a reason this Pull Request is still a draft? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5784
Completes the
userPoolEndpointImplementationThis PR completes completes the implementation started in commit
f37cb7e69which addeduserPoolEndpointtoAuthOutputsbut was missing a critical mapping step.Problem
The original work added the
userPoolEndpointfield to support custom Cognito endpoints (e.g., routing through a proxy), but the implementation was incomplete. The endpoint was being collected from Gen 1 configs but never actually passed to the Cognito User Pool configuration.Root Cause
The
CognitoUserPoolConfig.fromAuthOutputs()factory method was missing the endpoint mapping, breaking the configuration flow: