Skip to content

Update to ACK runtime v0.43.0, code-generator v0.43.1 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ack_generate_info:
build_date: "2025-02-18T00:54:04Z"
build_hash: 66c0f840b0bcf6f552be46cf5ee0fb95ad57053e
go_version: go1.23.6
version: v0.43.0
api_directory_checksum: 1ef7595c70d504b08f54fe5c2a16eabf46999aea
build_date: "2025-02-19T23:18:34Z"
build_hash: 8b426c490ff1984d8ce5577e11d6dabe1b6373b8
go_version: go1.24.0
version: v0.43.1
api_directory_checksum: 18f4ce08c6d885a2e95716b63874422387df5a0f
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
generator_config_info:
Expand Down
10 changes: 9 additions & 1 deletion apis/v1alpha1/rule.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion config/controller/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ kind: Kustomization
images:
- name: controller
newName: public.ecr.aws/aws-controllers-k8s/recyclebin-controller
newTag: 1.0.4
newTag: 1.0.5
27 changes: 2 additions & 25 deletions config/crd/bases/recyclebin.services.k8s.aws_rules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,9 @@ spec:
description: RuleSpec defines the desired state of Rule.
properties:
description:
description: The retention rule description.
type: string
lockConfiguration:
description: Information about the retention rule lock configuration.
description: Information about a retention rule lock configuration.
properties:
unlockDelay:
description: |-
Expand All @@ -60,22 +59,6 @@ spec:
type: object
type: object
resourceTags:
description: |-
[Tag-level retention rules only] Specifies the resource tags to use to identify
resources that are to be retained by a tag-level retention rule. For tag-level
retention rules, only deleted resources, of the specified resource type,
that have one or more of the specified tag key and value pairs are retained.
If a resource is deleted, but it does not have any of the specified tag key
and value pairs, it is immediately deleted without being retained by the
retention rule.

You can add the same tag key and value pair to a maximum or five retention
rules.

To create a Region-level retention rule, omit this parameter. A Region-level
retention rule does not have any resource tags specified. It retains all
deleted resources of the specified resource type in the Region in which the
rule is created, even if the resources are not tagged.
items:
description: |-
[Tag-level retention rules only] Information about the resource tags used
Expand All @@ -88,10 +71,6 @@ spec:
type: object
type: array
resourceType:
description: |-
The resource type to be retained by the retention rule. Currently, only Amazon
EBS snapshots and EBS-backed AMIs are supported. To retain snapshots, specify
EBS_SNAPSHOT. To retain EBS-backed AMIs, specify EC2_IMAGE.
type: string
retentionPeriod:
description: |-
Expand All @@ -105,8 +84,6 @@ spec:
type: integer
type: object
tags:
description: Information about the tags to assign to the retention
rule.
items:
description: Information about the tags to assign to the retention
rule.
Expand Down Expand Up @@ -155,7 +132,7 @@ spec:
type: object
conditions:
description: |-
All CRS managed by ACK have a common `Status.Conditions` member that
All CRs managed by ACK have a common `Status.Conditions` member that
contains a collection of `ackv1alpha1.Condition` objects that describe
the various terminal states of the CR and its backend AWS service API
resource
Expand Down
4 changes: 2 additions & 2 deletions helm/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v1
name: recyclebin-chart
description: A Helm chart for the ACK service controller for Amazon EBS Recycle Bin (Recycle Bin)
version: 1.0.4
appVersion: 1.0.4
version: 1.0.5
appVersion: 1.0.5
home: https://github.com/aws-controllers-k8s/recyclebin-controller
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
sources:
Expand Down
27 changes: 2 additions & 25 deletions helm/crds/recyclebin.services.k8s.aws_rules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,9 @@ spec:
description: RuleSpec defines the desired state of Rule.
properties:
description:
description: The retention rule description.
type: string
lockConfiguration:
description: Information about the retention rule lock configuration.
description: Information about a retention rule lock configuration.
properties:
unlockDelay:
description: |-
Expand All @@ -60,22 +59,6 @@ spec:
type: object
type: object
resourceTags:
description: |-
[Tag-level retention rules only] Specifies the resource tags to use to identify
resources that are to be retained by a tag-level retention rule. For tag-level
retention rules, only deleted resources, of the specified resource type,
that have one or more of the specified tag key and value pairs are retained.
If a resource is deleted, but it does not have any of the specified tag key
and value pairs, it is immediately deleted without being retained by the
retention rule.

You can add the same tag key and value pair to a maximum or five retention
rules.

To create a Region-level retention rule, omit this parameter. A Region-level
retention rule does not have any resource tags specified. It retains all
deleted resources of the specified resource type in the Region in which the
rule is created, even if the resources are not tagged.
items:
description: |-
[Tag-level retention rules only] Information about the resource tags used
Expand All @@ -88,10 +71,6 @@ spec:
type: object
type: array
resourceType:
description: |-
The resource type to be retained by the retention rule. Currently, only Amazon
EBS snapshots and EBS-backed AMIs are supported. To retain snapshots, specify
EBS_SNAPSHOT. To retain EBS-backed AMIs, specify EC2_IMAGE.
type: string
retentionPeriod:
description: |-
Expand All @@ -105,8 +84,6 @@ spec:
type: integer
type: object
tags:
description: Information about the tags to assign to the retention
rule.
items:
description: Information about the tags to assign to the retention
rule.
Expand Down Expand Up @@ -155,7 +132,7 @@ spec:
type: object
conditions:
description: |-
All CRS managed by ACK have a common `Status.Conditions` member that
All CRs managed by ACK have a common `Status.Conditions` member that
contains a collection of `ackv1alpha1.Condition` objects that describe
the various terminal states of the CR and its backend AWS service API
resource
Expand Down
2 changes: 1 addition & 1 deletion helm/templates/NOTES.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{ .Chart.Name }} has been installed.
This chart deploys "public.ecr.aws/aws-controllers-k8s/recyclebin-controller:1.0.4".
This chart deploys "public.ecr.aws/aws-controllers-k8s/recyclebin-controller:1.0.5".

Check its status by running:
kubectl --namespace {{ .Release.Namespace }} get pods -l "app.kubernetes.io/instance={{ .Release.Name }}"
Expand Down
2 changes: 1 addition & 1 deletion helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

image:
repository: public.ecr.aws/aws-controllers-k8s/recyclebin-controller
tag: 1.0.4
tag: 1.0.5
pullPolicy: IfNotPresent
pullSecrets: []

Expand Down