Skip to content

Conversation

@michaelhtm
Copy link
Member

Issue #2693

Description of changes:
Currently, when a resource has the adopt-or-create annotation,
and the controller successfully adopts the resource, we immediately
check if there are any deltas and make an update call if needed.

This has been problematic for some controllers, since most return
the desired status (which will be empty during adopt-or-create).

This change ensures we update the resource status with the latest
information from AWS, requeue and handle any updates if needed,
ensuring no information is lost.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and rushmash91 November 16, 2025 02:01
@ack-prow ack-prow bot added the approved label Nov 16, 2025
@a-hilaly
Copy link
Member

/retest

1 similar comment
@a-hilaly
Copy link
Member

/retest

@michaelhtm michaelhtm force-pushed the fix/patchstatusfirstonadoptorcreate branch from 1fedac6 to 645ac5d Compare November 22, 2025 00:29
Copy link

@knottnt knottnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,knottnt,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm
Copy link
Member Author

/retest s3-controller-test

@ack-prow
Copy link

ack-prow bot commented Nov 22, 2025

@michaelhtm: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test ec2-controller-test
  • /test ecr-controller-test
  • /test iam-controller-test
  • /test s3-controller-test
  • /test sagemaker-controller-test
  • /test sqs-controller-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test verify-attribution

Use /test all to run all jobs.

In response to this:

/retest s3-controller-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelhtm
Copy link
Member Author

/test s3-controller-test

@michaelhtm
Copy link
Member Author

/test sagemaker-controller-test

@michaelhtm
Copy link
Member Author

/test s3-controller-test

1 similar comment
@michaelhtm
Copy link
Member Author

/test s3-controller-test

@ack-prow
Copy link

ack-prow bot commented Nov 22, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 645ac5d link false /test verify-attribution
s3-controller-test 645ac5d link true /test s3-controller-test
sagemaker-controller-test 645ac5d link true /test sagemaker-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants