-
Notifications
You must be signed in to change notification settings - Fork 180
fix: ensure resource status is patched before checking for updates on #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: ensure resource status is patched before checking for updates on #213
Conversation
|
/retest |
1 similar comment
|
/retest |
1fedac6 to
645ac5d
Compare
knottnt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, knottnt, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest s3-controller-test |
|
@michaelhtm: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test s3-controller-test |
|
/test sagemaker-controller-test |
|
/test s3-controller-test |
1 similar comment
|
/test s3-controller-test |
|
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issue #2693
Description of changes:
Currently, when a resource has the
adopt-or-createannotation,and the controller successfully adopts the resource, we immediately
check if there are any deltas and make an update call if needed.
This has been problematic for some controllers, since most return
the
desiredstatus (which will be empty during adopt-or-create).This change ensures we update the resource status with the latest
information from AWS, requeue and handle any updates if needed,
ensuring no information is lost.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.