fix(#798): Honor DOCKER_HOST environment variable for Docker API client #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-hu
requested review from
andrew-glenn,
tlindsay42 and
tonynv
as code owners
Author
|
I am not familiar with this... what should I do to make "Static Analysis" green? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
TaskCat fails when running in Kubernetes with contained runtime or in GitLab pipeline due to Docker daemon connection errors.
Testing/Steps taken to ensure quality
See issue #798. As long as the UNIX socket is not available, the error happens.
Solution
Allow users to specify a custom Docker host via the
DOCKER_HOSTenvironment variable, which is passed to the Docker APIClient constructor.Changes
DOCKER_HOSTif set, otherwise defaults tounix://var/run/docker.sockTesting Instructions
Test in an environment that the Docker daemon's UNIX socket is not accessible by the client, for example in a GitLab pipleine with docker:dind service.