New Automode Observability Patterns #189
Conversation
|
/do-e2e-test single-new-eks-awsnative-automode-observability deploy |
1 similar comment
|
/do-e2e-test single-new-eks-awsnative-automode-observability deploy |
|
/do-e2e-test single-new-eks-awsnative-automode-observability deploy |
4 similar comments
|
/do-e2e-test single-new-eks-awsnative-automode-observability deploy |
|
/do-e2e-test single-new-eks-awsnative-automode-observability deploy |
|
/do-e2e-test single-new-eks-awsnative-automode-observability deploy |
|
/do-e2e-test single-new-eks-awsnative-automode-observability deploy |
|
/do-e2e-test single-new-eks-awsnative-automode-observability destroy |
|
/do-2e2-test single-new-eks-automode-opensource-observability deploy |
|
/do-e2e-test single-new-eks-automode-opensource-observability deploy |
|
/do-e2e-test single-new-eks-automode-opensource-observability destroy |
There was a problem hiding this comment.
@zjaco13 Looks Great, love these two patterns. Documentation needs to be tighten up:
- Make sure mkdocs is updated with these two docs so we see new patterns in doc website
- I see some repeatations on things not really relevant to AutoMode. You can basically point to older docs
- Did you test mkdocs locally to see if the documentation pages are visible.
- Also the home md file should be updated with these new patterns in command outputs for
make list
| run_test: ${{ steps.checkUserPermissions.outputs.require-result }} | ||
| e2ePipeline: | ||
| runs-on: ubuntu-latest | ||
| permissions: |
There was a problem hiding this comment.
This is already in main, rebase
| @@ -0,0 +1,6 @@ | |||
| import { configureApp } from '../lib/common/construct-utils'; | |||
There was a problem hiding this comment.
I see name conflict. The naming scheme of patterns is single-new-eks-automode-opensource-observability.ts and single-new-eks-automode-awsnative-observability.ts. You are mixing it among your patterns. Please correct this uniformly
There was a problem hiding this comment.
should be resolved throughout
|
|
||
| const app = configureApp(); | ||
|
|
||
| new SingleNewEksAutoModeAWSNativeObservabilityPattern(app, 'single-new-eks-awsnative-automode'); |
There was a problem hiding this comment.
should be single-new-eks-automode-awsnative
|
|
||
| 4. GRAFANA API KEY: Amazon Managed Grafana provides a control plane API for generating Grafana API keys or Service Account Tokens. | ||
|
|
||
| === "v10.4 & v9.4 workspaces" |
There was a problem hiding this comment.
What is this "=== "v10.4 & v9.4 workspaces"" hanging out
| --output text) | ||
| ``` | ||
|
|
||
| === "v8.4 workspaces" |
There was a problem hiding this comment.
Oh i understand but make it look better like for v...
There was a problem hiding this comment.
looks better once docs are published
| Example settings: Update the context in `cdk.json` file located in `cdk-eks-blueprints-patterns` directory | ||
|
|
||
| ```typescript | ||
| "context": { |
There was a problem hiding this comment.
What is specific in this for automode?
There was a problem hiding this comment.
none, copied from non automode docs
| make pattern single-new-eks-automode-opensource-observability deploy | ||
| ``` | ||
|
|
||
| ## Verify the resources |
There was a problem hiding this comment.
Can we say something like wait for 20 mins or so before verifying
| make pattern single-new-eks-automode-opensource-observability destroy | ||
| ``` | ||
|
|
||
| ## Troubleshooting |
There was a problem hiding this comment.
If this is repeated, can you point the original troubleshooting document?
|
|
||
|  | ||
|
|
||
| ## Viewing Logs |
There was a problem hiding this comment.
Same feedback. If nothing specific to AM or new, point to old doc link
2 participants
Issue #, if available:
Description of changes:
2 new patterns for supporting automode in observability accelerator. Open Source and AWS Native
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.